From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#60176: 29.0.60; Fallback file variable mode if treesitter is not usable Date: Mon, 19 Dec 2022 19:29:13 +0200 Organization: LINKOV.NET Message-ID: <86o7rzfivi.fsf@mail.linkov.net> References: <61db3ccacc2697d0b740315af495fca2@sadiqpk.org> <86359bhmfx.fsf@mail.linkov.net> <83o7rzeflc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1277"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: sadiq@sadiqpk.org, monnier@iro.umontreal.ca, 60176@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 19 18:36:24 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p7K3r-0000Dv-Vf for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Dec 2022 18:36:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7K3Z-0001EB-7e; Mon, 19 Dec 2022 12:36:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7K3X-0001Dv-1p for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2022 12:36:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p7K3W-0006Cz-Pz for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2022 12:36:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p7K3W-0005HL-5o for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2022 12:36:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Dec 2022 17:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60176 X-GNU-PR-Package: emacs Original-Received: via spool by 60176-submit@debbugs.gnu.org id=B60176.167147131420279 (code B ref 60176); Mon, 19 Dec 2022 17:36:02 +0000 Original-Received: (at 60176) by debbugs.gnu.org; 19 Dec 2022 17:35:14 +0000 Original-Received: from localhost ([127.0.0.1]:39376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7K2k-0005H1-39 for submit@debbugs.gnu.org; Mon, 19 Dec 2022 12:35:14 -0500 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:56443) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7K2g-0005Gt-Dt for 60176@debbugs.gnu.org; Mon, 19 Dec 2022 12:35:12 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 8C7EB4000C; Mon, 19 Dec 2022 17:35:01 +0000 (UTC) In-Reply-To: <83o7rzeflc.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 19 Dec 2022 14:35:27 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251446 Archived-At: >> So to completely cover all needs, 'major-mode-remap-alist' should >> support a predicate as well. For example, >> >> (setq major-mode-remap-alist '((c-mode #'treesit-available-p c-ts-mode))) > > I think the idea is that this should happen by default, not as a > (not-so-trivial) customization by the users. Then 'c-ts-mode' should fall back to 'c-mode' when treesit is not available? Like this: ``` diff --git a/lisp/progmodes/c-ts-mode.el b/lisp/progmodes/c-ts-mode.el index cf941236f82..5004b9a5e1d 100644 --- a/lisp/progmodes/c-ts-mode.el +++ b/lisp/progmodes/c-ts-mode.el @@ -616,7 +616,7 @@ c-ts-mode (define-derived-mode c-ts-mode c-ts-base-mode "C" (unless (treesit-ready-p 'c) - (error "Tree-sitter for C isn't available")) + (c-mode)) (treesit-parser-create 'c) ```