From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Liu Hui <liuhui1610@gmail.com>,
67161@debbugs.gnu.org, stefankangas@gmail.com,
monnier@iro.umontreal.ca
Subject: bug#67161: 30.0.50; [PATCH] Add option `dired-filename-display-length'
Date: Mon, 20 Nov 2023 19:54:27 +0200 [thread overview]
Message-ID: <86o7foqpu8.fsf@mail.linkov.net> (raw)
In-Reply-To: <835y1wk4ls.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 20 Nov 2023 14:10:23 +0200")
>> Therefore, I would like to change
>>
>> (put-text-property ell-beg (point) 'invisible 'dired-filename-hide)
>>
>> to
>>
>> (let ((ov (make-overlay ell-beg (point))))
>> (overlay-put ov 'invisible 'dired-filename-hide)
>> (overlay-put ov 'isearch-open-invisible t)
>> (overlay-put ov 'evaporate t))
>
> Juri, this seems to be a usability bug? Why does Isearch only look
> into invisible overlay properties, but not text properties? IOW, why
> doesn't "M-s i" set the value of isearch-invisible to t, not 'open'?
> Or maybe 'open' should also search inside text properties, not just
> overlays? In any case, the differences between properties and
> overlays is unusual and IMO a misfeature. Can this be fixed?
I recall Ihor implemented the revealing of invisible text properties
for Org-mode when overlays were very slow. But now overlays are
optimized, so Liu is absolutely right that better to use overlays.
next prev parent reply other threads:[~2023-11-20 17:54 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 9:52 bug#67161: 30.0.50; [PATCH] Add option `dired-filename-display-length' Liu Hui
2023-11-14 13:26 ` Eli Zaretskii
2023-11-15 10:04 ` Liu Hui
2023-11-15 12:32 ` Eli Zaretskii
2023-11-16 10:07 ` Liu Hui
2023-11-16 12:11 ` Eli Zaretskii
2023-11-18 9:23 ` Liu Hui
2023-11-18 10:55 ` Eli Zaretskii
2023-11-18 16:12 ` Drew Adams
2023-11-20 4:34 ` Liu Hui
2023-11-20 12:10 ` Eli Zaretskii
2023-11-20 17:54 ` Juri Linkov [this message]
2023-11-20 18:42 ` Eli Zaretskii
2023-11-20 18:55 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-20 19:17 ` Eli Zaretskii
2023-11-21 7:52 ` Juri Linkov
2023-11-21 11:55 ` Eli Zaretskii
2023-11-21 17:12 ` Juri Linkov
2023-11-20 17:20 ` Drew Adams
2023-11-22 5:41 ` Liu Hui
2023-11-25 10:52 ` Eli Zaretskii
2023-11-25 17:51 ` Juri Linkov
2023-11-25 20:02 ` Eli Zaretskii
2023-11-26 2:56 ` Liu Hui
2023-11-26 5:59 ` Eli Zaretskii
2023-11-26 10:49 ` Eli Zaretskii
2023-11-26 14:03 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-26 14:53 ` Eli Zaretskii
2023-11-26 17:08 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-26 17:58 ` Eli Zaretskii
2023-11-26 18:06 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-27 7:19 ` Juri Linkov
2023-11-27 8:32 ` Liu Hui
2023-11-27 17:16 ` Juri Linkov
2023-11-15 18:06 ` Drew Adams
2023-11-15 15:54 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-16 3:44 ` Liu Hui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86o7foqpu8.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=67161@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=liuhui1610@gmail.com \
--cc=monnier@iro.umontreal.ca \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).