From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.bugs Subject: bug#67005: 30.0.50; improve nadivce/comp/trampoline handling Date: Mon, 04 Dec 2023 23:57:57 +0000 Message-ID: <86o7f5jzay.fsf@gmail.com> References: <874jhv9921.fsf@sappc2.fritz.box> <875y24zrt1.fsf@sappc2.fritz.box> <87ttpmwuxi.fsf@sappc2.fritz.box> <877cmct4a1.fsf@sappc2.fritz.box> <87bkbmiwpf.fsf@sappc2.fritz.box> <87leap8n1z.fsf@sappc2.fritz.box> <87leaob192.fsf@sappc2.fritz.box> <871qcegg43.fsf@sappc2.fritz.box> <87plzxu1ea.fsf@vodafonemail.de> <87ttoxu3wh.fsf@sappc2.fritz.box> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35190"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (windows-nt) To: 67005@debbugs.gnu.org Cancel-Lock: sha1:UvBT1yb6XgAAQ++RoGGqWR2vNaU= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 05 00:59:12 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rAIqF-0008uj-GQ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 Dec 2023 00:59:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rAIpx-00027O-MW; Mon, 04 Dec 2023 18:58:53 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rAIpw-00026h-4s for bug-gnu-emacs@gnu.org; Mon, 04 Dec 2023 18:58:52 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rAIpv-0004YH-QK for bug-gnu-emacs@gnu.org; Mon, 04 Dec 2023 18:58:51 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rAIq6-0001f5-1H for bug-gnu-emacs@gnu.org; Mon, 04 Dec 2023 18:59:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <874jhv9921.fsf@sappc2.fritz.box> Resent-From: Andy Moreton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Dec 2023 23:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67005 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.17017343106349 (code B ref -1); Mon, 04 Dec 2023 23:59:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 4 Dec 2023 23:58:30 +0000 Original-Received: from localhost ([127.0.0.1]:36135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rAIpZ-0001eK-Nd for submit@debbugs.gnu.org; Mon, 04 Dec 2023 18:58:30 -0500 Original-Received: from lists.gnu.org ([2001:470:142::17]:39386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rAIpX-0001e8-R5 for submit@debbugs.gnu.org; Mon, 04 Dec 2023 18:58:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rAIpH-0001yA-K0 for bug-gnu-emacs@gnu.org; Mon, 04 Dec 2023 18:58:11 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rAIpG-0004OQ-3i for bug-gnu-emacs@gnu.org; Mon, 04 Dec 2023 18:58:11 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1rAIpC-0007Vg-DO for bug-gnu-emacs@gnu.org; Tue, 05 Dec 2023 00:58:06 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275544 Archived-At: On Mon 04 Dec 2023, Andrea Corallo wrote: > Jens Schmidt writes: > >> Jens Schmidt writes: >> >>> Patch reworked accordingly, also to include the additional commit >>> message Andreas has proposed. Please review. >> >> 10 days (inclusive) have passed, so: Gentle Bump. Is there anything >> still missing here? >> >> Thanks Jens > > Hi Jens, > > I've installed your patch into master with e670412a3e1. > > I'm closing the bug as well, happy to re-poen if necessary. > > Thanks > > Andrea Commit e670412a3e10 ("Update handling of advices during preload") appears to break bootstrap on Windows with the 64bit mingw64 toolchain: Error: error ("Preload advice on insert-directory") mapbacktrace((closure ((prin1 . cl-prin1) t) (evald func args _flags) (let ((args args)) (if evald (progn (princ " ") (funcall prin1 func) (princ "(")) (progn (princ " ( ") (setq args (cons func args)))) (if args (while (progn (funcall prin1 (car args)) (setq args (cdr args)))(princ " "))) (princ ")\n")))) (let ((print-escape-newlines t) (print-escape-control-characters t) (print-escape-nonascii t) (prin1 (if (and (fboundp 'cl-prin1) (fboundp 'cl-defmethod) (condition-case n il (require 'cl-print) (error nil))) #'cl-prin1 #'prin1))) (mapbacktrace #'(lambda (evald func args _flags) (let ((args args)) (if evald (progn (princ " ") (funcall prin1 f unc) (princ "(")) (progn (princ " (") (setq args (cons func args)))) (if args (while (progn (funcall prin1 (car args)) (setq args (cdr args))) (princ " "))) (princ ")\n"))) )) debug-early-backtrace() debug-early(error (error "Preload advice on insert-directory")) signal(error ("Preload advice on insert-directory")) error("Preload advice on %s" insert-directory) (and (advice--p (symbol-function f)) (error "Preload advice on %s" f)) (closure (t) (f) (and (advice--p (symbol-function f)) (error "Preload advice on %s" f)))(insert-directory) mapatoms((closure(t) (f) (and (advice--p (symbol-function f)) (error "Preload advice on %s" f)))) load("loadup.el") Preload advice on insert-directory make[2]: *** [Makefile:1014: bootstrap-emacs.pdmp] Error 127 make[1]: *** [Makefile:554: src] Error 2 Bootstrapping the same config with commit f5e45247081a ("comp: Fix mvar dependency chain (bug#67239)") succeeds. Both builds done from a clean checkout after "git clean -xdf". AndyM