From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#68214: Completion sorting customization by category Date: Tue, 09 Jan 2024 19:59:13 +0200 Organization: LINKOV.NET Message-ID: <86o7dul766.fsf@mail.linkov.net> References: <86a5pnzst1.fsf@mail.linkov.net> <868r5630ft.fsf@mail.linkov.net> <8ebc33fb-d01f-4426-a716-69a11f6dfad1@daniel-mendler.de> <86le95m2ue.fsf@mail.linkov.net> <86sf3cjj6o.fsf@mail.linkov.net> <871qawrxh0.fsf@daniel-mendler.de> <86r0iuxu4f.fsf@mail.linkov.net> <87plye9wbz.fsf@daniel-mendler.de> <86wmslhvdk.fsf@mail.linkov.net> <87h6jpdm63.fsf@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2039"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 68214@debbugs.gnu.org To: Daniel Mendler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 09 19:01:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNGPa-0000KF-IN for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Jan 2024 19:01:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNGPL-0006Fv-9a; Tue, 09 Jan 2024 13:00:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNGPJ-0006Fh-NL for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 13:00:57 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNGPH-0008RP-9D for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 13:00:55 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rNGPN-00046w-Tb for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 13:01:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jan 2024 18:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68214 X-GNU-PR-Package: emacs Original-Received: via spool by 68214-submit@debbugs.gnu.org id=B68214.170482325615228 (code B ref 68214); Tue, 09 Jan 2024 18:01:01 +0000 Original-Received: (at 68214) by debbugs.gnu.org; 9 Jan 2024 18:00:56 +0000 Original-Received: from localhost ([127.0.0.1]:40884 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNGPH-0003x8-So for submit@debbugs.gnu.org; Tue, 09 Jan 2024 13:00:56 -0500 Original-Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]:47555) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNGPF-0003ir-K2 for 68214@debbugs.gnu.org; Tue, 09 Jan 2024 13:00:54 -0500 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 2D6C760007; Tue, 9 Jan 2024 18:00:38 +0000 (UTC) In-Reply-To: <87h6jpdm63.fsf@daniel-mendler.de> (Daniel Mendler's message of "Sun, 07 Jan 2024 19:37:56 +0100") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277640 Archived-At: >> What do you think about doing the same for >> `completion-extra-properties'? > > Yes, makes sense. The documentation of `completion-extra-properties' > would have to be extended accordingly, mentioning all the newly > supported properties. It bothers me a little bit that the > `completion-metadata-get' lookup wouldn't be allocation-free anymore > (because of keywords versus plain symbols), but one could cache the > keyword symbol. > > (defun completion-metadata-get (metadata prop) > "Get property PROP from completion METADATA. > If the metadata specifies a completion category, the variables > `completion-category-overrides' and > `completion-category-defaults' take precedence for > category-specific overrides. If the completion metadata does not > specify the property, the `completion-extra-properties' plist is > consulted. Note that the keys of the > `completion-extra-properties' plist are keyword symbols, not > plain symbols." > (if-let (((not (eq prop 'category))) > (cat (alist-get 'category metadata)) > (over (completion--category-override cat prop))) > (cdr over) > (or (alist-get prop metadata) > (plist-get completion-extra-properties > ;; Cache the keyword > (or (get prop 'completion-extra-properties--keyword) > (put prop 'completion-extra-properties--keyword > (intern (concat ":" (symbol-name prop))))))))) Thanks, this is now pushed as well in the commit aff1d53cd46. Now I tried to use a more user-friendly let-binding of 'completion-extra-properties' like below, but then discovered that it doesn't work for the category. Maybe 'completion-metadata-get' could try to get a category from 'completion-extra-properties' as well? diff --git a/lisp/calendar/calendar.el b/lisp/calendar/calendar.el index e01d5d792a6..2c3e7d28301 100644 --- a/lisp/calendar/calendar.el +++ b/lisp/calendar/calendar.el @@ -2337,14 +2337,12 @@ calendar-read-date (defmon (aref month-array (1- (calendar-extract-month default-date)))) (completion-ignore-case t) (month (cdr (assoc-string - (completing-read - (format-prompt "Month name" defmon) - (lambda (string pred action) - (if (eq action 'metadata) - '(metadata (category . calendar-month)) - (complete-with-action - action (append month-array nil) string pred))) - nil t nil nil defmon) + (let ((completion-extra-properties + '(:category calendar-month))) + (completing-read + (format-prompt "Month name" defmon) + (append month-array nil) + nil t nil nil defmon)) (calendar-make-alist month-array 1) t))) (defday (calendar-extract-day default-date)) (last (calendar-last-day-of-month month year)))