From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71176: 30.0.50; Segmentation fault (SIGSEGV) in TTY+emacsclient, default_face is nil Date: Sat, 25 May 2024 21:07:06 +0300 Message-ID: <86o78tyddh.fsf@gnu.org> References: <86r0dr106n.fsf@gnu.org> <867cfiyset.fsf@gnu.org> <86r0dpyfa8.fsf@gnu.org> <86plt9ye94.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30617"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71176@debbugs.gnu.org To: n142857@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 25 20:08:27 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sAvoh-0007ku-CK for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 May 2024 20:08:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sAvoG-0005iC-At; Sat, 25 May 2024 14:08:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sAvoA-0005hX-5r for bug-gnu-emacs@gnu.org; Sat, 25 May 2024 14:07:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sAvo9-0007oI-UW for bug-gnu-emacs@gnu.org; Sat, 25 May 2024 14:07:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sAvoH-0005vE-I6 for bug-gnu-emacs@gnu.org; Sat, 25 May 2024 14:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 May 2024 18:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71176 X-GNU-PR-Package: emacs Original-Received: via spool by 71176-submit@debbugs.gnu.org id=B71176.171666044622754 (code B ref 71176); Sat, 25 May 2024 18:08:01 +0000 Original-Received: (at 71176) by debbugs.gnu.org; 25 May 2024 18:07:26 +0000 Original-Received: from localhost ([127.0.0.1]:44856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAvni-0005uw-7A for submit@debbugs.gnu.org; Sat, 25 May 2024 14:07:26 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAvng-0005uq-Dh for 71176@debbugs.gnu.org; Sat, 25 May 2024 14:07:24 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sAvnT-0007lU-1q; Sat, 25 May 2024 14:07:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=LkF1tdq3t812sxBiGaEK8YEYh3/B+HlAfknkKheSk6o=; b=B8e+3P0TNbfI HI2uPlxGw5b7GdZeQE6ANPrDj4Vi3PAkUPrpo6zOUKB8U91Y0z+w17y/1yTMeSYwzN4Q09cU3YBjP y2Mun3hKxqIrBYPkrtEJbbBmlHsa1zSglkHCaRM3zNQQoqIL90BUFVUVudDKF4AP+NLkzT8GhQYfO iXo8icV7pL2cw03/Xu7Sakcc1baQSP7WsspV44M5iKBUN8LwZiZYNsT5nwEF2ax8pu8jbx0i/1NOp vzw9GzEtNfmb95NM0+pysplMSJ4bqYsnxc+cYDvXU2dBQpEf09AzWtLWlsAG2oTP0Pf98J7We+2iF U+7XECe0CvbZww0Kc++jmw==; In-Reply-To: <86plt9ye94.fsf@gnu.org> (message from Eli Zaretskii on Sat, 25 May 2024 20:48:07 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285903 Archived-At: > Cc: 71176@debbugs.gnu.org > Date: Sat, 25 May 2024 20:48:07 +0300 > From: Eli Zaretskii > > And also, please try the patch below. Sorry, that is not enough. Please try the patch below instead. diff --git a/src/xdisp.c b/src/xdisp.c index 7a00b29..47675fc 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -13377,8 +13377,10 @@ echo_area_display (bool update_frame_p) w = XWINDOW (mini_window); f = XFRAME (WINDOW_FRAME (w)); - /* Don't display if frame is invisible or not yet initialized. */ - if (!FRAME_REDISPLAY_P (f) || !f->glyphs_initialized_p) + /* Don't display if frame is invisible or not yet initialized or + if redisplay is inhibited. */ + if (!FRAME_REDISPLAY_P (f) || !f->glyphs_initialized_p + || !NILP (Vinhibit_redisplay)) return; #ifdef HAVE_WINDOW_SYSTEM diff --git a/src/xfaces.c b/src/xfaces.c index 5192b22..340f181 100644 --- a/src/xfaces.c +++ b/src/xfaces.c @@ -4246,6 +4246,12 @@ DEFUN ("internal-merge-in-global-face", Finternal_merge_in_global_face, /* This can be NULL (e.g., in batch mode). */ if (oldface) { + /* In some cases, realize_face below can call Lisp, which could + trigger redisplay. But we are in the process of realizing + the default face, and therefore are not ready to do display. */ + specpdl_ref count = SPECPDL_INDEX (); + specbind (Qinhibit_redisplay, Qt); + /* Ensure that the face vector is fully specified by merging the previously-cached vector. */ memcpy (attrs, oldface->lface, sizeof attrs); @@ -4291,6 +4297,8 @@ DEFUN ("internal-merge-in-global-face", Finternal_merge_in_global_face, gvec[LFACE_BACKGROUND_INDEX]); Fmodify_frame_parameters (frame, arg); } + + unbind_to (count, Qnil); } }