From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71159: [PATCH] Stipple support for MS Windows Date: Sat, 01 Jun 2024 17:28:03 +0300 Message-ID: <86o78kohzg.fsf@gnu.org> References: <86cypcuhhk.fsf@gmail.com> <86jzjcgq00.fsf@gmail.com> <86sexydekl.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4873"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71159@debbugs.gnu.org To: "Elijah G." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 01 16:29:09 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sDPjI-000158-F3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 01 Jun 2024 16:29:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sDPj2-0007Oa-53; Sat, 01 Jun 2024 10:28:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sDPj0-0007OE-KE for bug-gnu-emacs@gnu.org; Sat, 01 Jun 2024 10:28:50 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sDPj0-0004JW-CQ for bug-gnu-emacs@gnu.org; Sat, 01 Jun 2024 10:28:50 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sDPjB-0007LS-Pb for bug-gnu-emacs@gnu.org; Sat, 01 Jun 2024 10:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Jun 2024 14:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71159 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71159-submit@debbugs.gnu.org id=B71159.171725210728196 (code B ref 71159); Sat, 01 Jun 2024 14:29:01 +0000 Original-Received: (at 71159) by debbugs.gnu.org; 1 Jun 2024 14:28:27 +0000 Original-Received: from localhost ([127.0.0.1]:56993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDPid-0007Kh-2g for submit@debbugs.gnu.org; Sat, 01 Jun 2024 10:28:27 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60100) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDPib-0007KQ-4H for 71159@debbugs.gnu.org; Sat, 01 Jun 2024 10:28:25 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sDPiK-0004Fv-1n; Sat, 01 Jun 2024 10:28:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=y2xvTnZ2vdY2czbeF5Q+WKBBXyzsUHCrIonism0y738=; b=YPmEPTAZnapf x8oGmu1qjOR04Z38IwaasRNc+0UgBNMlOSBEW9ekErh5zsmcLGvOF6lI6sWYfgRl4ni3KgBerj/fa jFMhZUwv3Whe07sM+8lf7VG+PUJl6JN1iL1PU2HTNETvrdnX9h6/1z2dTCZoUI/fQTiYfrWrhATew aWEomH34n0YghVO/mS1Y77k9uC1uXIa2J4RVvSW+ULD06+GGRCzbVoLSAjlQHIYi/1ZxbRuyBG9Mm cEnIU/Ubu9THTOzCof2ANoxuhuH/UXkml2g0B/rORqHKl8qNfY+5aZJBPd2f5eM//5J/yZuNaNnwn 9YkITwBywUyFjR5ksEwsmA==; In-Reply-To: <86sexydekl.fsf@gmail.com> (eg642616@gmail.com) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286329 Archived-At: > From: "Elijah G." > Cc: Eli Zaretskii > Date: Thu, 30 May 2024 18:12:42 -0600 > > I've updated the patch for delete all the conflicts generated by > ae7d0e86b37eabc434c48f85f56df0a221e0e7c7 commit. Thanks, but is this the right patch? It includes a syntax error, which GCC announces like this: image.c: In function 'image_create_bitmap_from_data': image.c:627:26: error: expected ';' before 'do' 627 | sa_avail = MAX_ALLOCA | ^ | ; image.c:623:15: warning: variable 'sa_avail' set but not used [-Wunused-but-set-variable] 623 | ptrdiff_t sa_avail; /* Used only for SAFE_NALLOCA. */ | ^~~~~~~~ Makefile:457: recipe for target `image.o' failed make[2]: *** [image.o] Error 1 I'm guessing that you sent the wrong patch, because you couldn't have built Emacs with this one. So, while the fix is trivial, I haven't installed this, out of fear that other parts might be incorrect.