From: Eli Zaretskii <eliz@gnu.org>
To: Spencer Baugh <sbaugh@janestreet.com>, Dmitry Gutov <dmitry@gutov.dev>
Cc: joaotavora@gmail.com, 71823@debbugs.gnu.org
Subject: bug#71823: 31.0.50; project-mode-line and eglot duplicate project-name in mode-line
Date: Sat, 29 Jun 2024 10:12:24 +0300 [thread overview]
Message-ID: <86o77kjk87.fsf@gnu.org> (raw)
In-Reply-To: <CAO=BR8M0bc-3MHXZP9hDzXpnSM2NMwZ=MP+EGfcMMue1-p39qg@mail.gmail.com> (message from Spencer Baugh on Fri, 28 Jun 2024 18:08:41 -0400)
> From: Spencer Baugh <sbaugh@janestreet.com>
> Date: Fri, 28 Jun 2024 18:08:41 -0400
> Cc: Eli Zaretskii <eliz@gnu.org>, 71823@debbugs.gnu.org
>
> On Fri, Jun 28, 2024 at 1:49 PM João Távora <joaotavora@gmail.com> wrote:
>
> On Fri, Jun 28, 2024 at 3:41 PM Eli Zaretskii <eliz@gnu.org> wrote:
>
> > João, any comments?
>
> Tiny switches for these customizations is not a good idea. It's complex,
> hard to find, and doesn't scale well
>
> For this and other use cases we need something more robust like
> in many packages, a user-customizable eglot-mode-line-format. You
> can e.g. use flymake-mode-like-format as an idea. Of course,
> the default value of eglot-mode-line-format would keep the
> Eglot mode-line exactly as it is.
>
> Yes, I agree.
>
> But my goal here isn't to make eglot-mode-line customizable, it's to add code to make the eglot mode line
> automatically avoid duplicating project-name.
>
> I figured some people might want to disable this code, so I made it customizable, but that customization is not
> essential. I'm happy to remove the customization, and just have the eglot modeline automatically remove the
> project-name when project-mode-line is set. That removes the need for any new customization variables,
> while still fixing the issue of duplication.
>
> Support for actual customization of the eglot mode line can be added later with an eglot-mode-line-format, as
> you suggest.
Why not turn the table and consider this to be a problem of
project.el, to be solved there? After all, the project-mode-line
option belongs to project.el, so the fact that it adds the project
name to the mode line too indiscriminately can legitimately be
considered to be a problem with that option. Right? On top of that,
project-mode-line is new in Emacs 30, whereas Eglot has been showing
the project in its mode line before that. So once again, IMO the onus
is on project.el to fix this somehow. For example, by not adding this
to the mode line in Eglot-controlled buffers.
Adding Dmitry to the discussion.
next prev parent reply other threads:[~2024-06-29 7:12 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-28 14:13 bug#71823: 31.0.50; project-mode-line and eglot duplicate project-name in mode-line Spencer Baugh
2024-06-28 14:15 ` Spencer Baugh
2024-06-28 14:40 ` Eli Zaretskii
2024-06-28 17:49 ` João Távora
2024-06-28 22:08 ` Spencer Baugh
2024-06-29 7:12 ` Eli Zaretskii [this message]
2024-06-29 11:59 ` Dmitry Gutov
2024-06-29 12:43 ` Eli Zaretskii
2024-06-30 6:50 ` Juri Linkov
2024-06-30 10:25 ` João Távora
2024-06-29 12:05 ` João Távora
2024-06-29 12:17 ` Dmitry Gutov
2024-06-29 12:21 ` João Távora
2024-06-29 12:41 ` Spencer Baugh
2024-06-29 14:24 ` Spencer Baugh
2024-06-30 0:25 ` João Távora
2024-06-30 12:51 ` sbaugh
2024-06-30 14:53 ` João Távora
2024-06-30 15:05 ` João Távora
2024-07-03 13:17 ` Spencer Baugh
2024-07-03 13:59 ` João Távora
2024-07-03 14:47 ` Spencer Baugh
2024-07-03 14:57 ` João Távora
2024-07-03 15:12 ` Spencer Baugh
2024-07-03 16:03 ` João Távora
2024-07-03 17:10 ` sbaugh
2024-07-05 12:04 ` João Távora
2024-07-15 13:30 ` Spencer Baugh
2024-06-30 16:38 ` Juri Linkov
2024-07-03 13:00 ` Spencer Baugh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86o77kjk87.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=71823@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=joaotavora@gmail.com \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).