* bug#72077: 30.0.60; customizing which-key-dont-use-unicode to nil results in nil which-key-separator
@ 2024-07-12 14:31 Robert Pluim
2024-07-13 12:12 ` Eli Zaretskii
0 siblings, 1 reply; 5+ messages in thread
From: Robert Pluim @ 2024-07-12 14:31 UTC (permalink / raw)
To: 72077; +Cc: Philip Kaludercic
mkdir /tmp/emacs-30
HOME=/tmp/emacs-30 src/emacs
M-x which-key-mode
M-x customize-variable which-key-dont-use-unicode RET
toggle it to nil, save it, resulting in the following .emacs:
;;; -*- lexical-binding: t -*-
(custom-set-variables
;; custom-set-variables was added by Custom.
;; If you edit it by hand, you could mess it up, so be careful.
;; Your init file should contain only one such instance.
;; If there is more than one, they won't work right.
'(which-key-dont-use-unicode nil))
(custom-set-faces
;; custom-set-faces was added by Custom.
;; If you edit it by hand, you could mess it up, so be careful.
;; Your init file should contain only one such instance.
;; If there is more than one, they won't work right.
)
C-x <pause> shows which-key using ?→ as separator
<exit emacs>
HOME=/tmp/emacs-30 src/emacs
C-h v which-key-dont-use-unicode RET
which-key-dont-use-unicode is a variable defined in ‘which-key.el’.
Its value is nil
Original value was t
C-h v which-key-separator RET
which-key-separator is a variable defined in ‘which-key.el’.
Its value is nil
Original value was " → "
C-h v which-key-ellipsis RET
which-key-ellipsis is a variable defined in ‘which-key.el’.
Its value is nil
Original value was "…"
M-x which-key-mode
C-x <pause> shows which-key using 'nil' as separator
Robert
--
In GNU Emacs 30.0.60 (build 13, x86_64-pc-linux-gnu, GTK+ Version
3.24.38, cairo version 1.16.0) of 2024-07-11 built on rltb
Repository revision: ec1e300a215504bb9905a31145924d7f3d2cb9ab
Repository branch: emacs-30
Windowing system distributor 'The X.Org Foundation', version 11.0.12009000
System Description: Debian GNU/Linux 12 (bookworm)
Configured using:
'configure -C --with-native-compilation=no'
Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB
^ permalink raw reply [flat|nested] 5+ messages in thread* bug#72077: 30.0.60; customizing which-key-dont-use-unicode to nil results in nil which-key-separator
2024-07-12 14:31 bug#72077: 30.0.60; customizing which-key-dont-use-unicode to nil results in nil which-key-separator Robert Pluim
@ 2024-07-13 12:12 ` Eli Zaretskii
2024-07-13 12:48 ` Philip Kaludercic
0 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2024-07-13 12:12 UTC (permalink / raw)
To: Robert Pluim, Justin Burkett; +Cc: 72077, philipk
> Cc: Philip Kaludercic <philipk@posteo.net>
> From: Robert Pluim <rpluim@gmail.com>
> Date: Fri, 12 Jul 2024 16:31:46 +0200
>
>
> mkdir /tmp/emacs-30
> HOME=/tmp/emacs-30 src/emacs
> M-x which-key-mode
> M-x customize-variable which-key-dont-use-unicode RET
>
> toggle it to nil, save it, resulting in the following .emacs:
>
> ;;; -*- lexical-binding: t -*-
> (custom-set-variables
> ;; custom-set-variables was added by Custom.
> ;; If you edit it by hand, you could mess it up, so be careful.
> ;; Your init file should contain only one such instance.
> ;; If there is more than one, they won't work right.
> '(which-key-dont-use-unicode nil))
> (custom-set-faces
> ;; custom-set-faces was added by Custom.
> ;; If you edit it by hand, you could mess it up, so be careful.
> ;; Your init file should contain only one such instance.
> ;; If there is more than one, they won't work right.
> )
>
> C-x <pause> shows which-key using ?→ as separator
>
> <exit emacs>
>
> HOME=/tmp/emacs-30 src/emacs
>
> C-h v which-key-dont-use-unicode RET
>
> which-key-dont-use-unicode is a variable defined in ‘which-key.el’.
>
> Its value is nil
> Original value was t
>
> C-h v which-key-separator RET
>
> which-key-separator is a variable defined in ‘which-key.el’.
>
> Its value is nil
> Original value was " → "
>
> C-h v which-key-ellipsis RET
>
> which-key-ellipsis is a variable defined in ‘which-key.el’.
>
> Its value is nil
> Original value was "…"
>
> M-x which-key-mode
> C-x <pause> shows which-key using 'nil' as separator
Justin, any comments or suggestions?
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#72077: 30.0.60; customizing which-key-dont-use-unicode to nil results in nil which-key-separator
2024-07-13 12:12 ` Eli Zaretskii
@ 2024-07-13 12:48 ` Philip Kaludercic
2024-07-15 7:25 ` Robert Pluim
0 siblings, 1 reply; 5+ messages in thread
From: Philip Kaludercic @ 2024-07-13 12:48 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 72077, Robert Pluim, Justin Burkett
[-- Attachment #1: Type: text/plain, Size: 2199 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
>> Cc: Philip Kaludercic <philipk@posteo.net>
>> From: Robert Pluim <rpluim@gmail.com>
>> Date: Fri, 12 Jul 2024 16:31:46 +0200
>>
>>
>> mkdir /tmp/emacs-30
>> HOME=/tmp/emacs-30 src/emacs
>> M-x which-key-mode
>> M-x customize-variable which-key-dont-use-unicode RET
>>
>> toggle it to nil, save it, resulting in the following .emacs:
>>
>> ;;; -*- lexical-binding: t -*-
>> (custom-set-variables
>> ;; custom-set-variables was added by Custom.
>> ;; If you edit it by hand, you could mess it up, so be careful.
>> ;; Your init file should contain only one such instance.
>> ;; If there is more than one, they won't work right.
>> '(which-key-dont-use-unicode nil))
>> (custom-set-faces
>> ;; custom-set-faces was added by Custom.
>> ;; If you edit it by hand, you could mess it up, so be careful.
>> ;; Your init file should contain only one such instance.
>> ;; If there is more than one, they won't work right.
>> )
>>
>> C-x <pause> shows which-key using ?→ as separator
>>
>> <exit emacs>
>>
>> HOME=/tmp/emacs-30 src/emacs
>>
>> C-h v which-key-dont-use-unicode RET
>>
>> which-key-dont-use-unicode is a variable defined in ‘which-key.el’.
>>
>> Its value is nil
>> Original value was t
>>
>> C-h v which-key-separator RET
>>
>> which-key-separator is a variable defined in ‘which-key.el’.
>>
>> Its value is nil
>> Original value was " → "
>>
>> C-h v which-key-ellipsis RET
>>
>> which-key-ellipsis is a variable defined in ‘which-key.el’.
>>
>> Its value is nil
>> Original value was "…"
>>
>> M-x which-key-mode
>> C-x <pause> shows which-key using 'nil' as separator
>
> Justin, any comments or suggestions?
This one is on me, I tweaked the 'which-key-dont-use-unicode' user
option.
The issue here seems to be that `custom-reevaluate-setting' always sets
a value, even if there is no `standard-value' associated with a user
option. I don't know if we want to change that (certainly not on the
release branch), but a quick fix seems to be this:
[-- Attachment #2: Type: text/plain, Size: 685 bytes --]
diff --git a/lisp/which-key.el b/lisp/which-key.el
index 973616ef116..49c22be216a 100644
--- a/lisp/which-key.el
+++ b/lisp/which-key.el
@@ -130,9 +130,10 @@ which-key-dont-use-unicode
`which-key-separator'."
:set (lambda (sym val)
(custom-set-default sym val)
- (mapc #'custom-reevaluate-setting
- '(which-key-separator
- which-key-ellipsis)))
+ (dolist (sym '(which-key-separator
+ which-key-ellipsis))
+ (when (get sym 'standard-value)
+ (custom-reevaluate-setting sym))))
:initialize #'custom-initialize-changed
:type 'boolean
:package-version "1.0" :version "30.1")
[-- Attachment #3: Type: text/plain, Size: 37 bytes --]
--
Philip Kaludercic on peregrine
^ permalink raw reply related [flat|nested] 5+ messages in thread* bug#72077: 30.0.60; customizing which-key-dont-use-unicode to nil results in nil which-key-separator
2024-07-13 12:48 ` Philip Kaludercic
@ 2024-07-15 7:25 ` Robert Pluim
2024-07-26 21:27 ` Philip Kaludercic
0 siblings, 1 reply; 5+ messages in thread
From: Robert Pluim @ 2024-07-15 7:25 UTC (permalink / raw)
To: Philip Kaludercic; +Cc: 72077, Eli Zaretskii, Justin Burkett
>>>>> On Sat, 13 Jul 2024 12:48:36 +0000, Philip Kaludercic <philipk@posteo.net> said:
Philip> The issue here seems to be that `custom-reevaluate-setting' always sets
Philip> a value, even if there is no `standard-value' associated with a user
Philip> option. I don't know if we want to change that (certainly not on the
Philip> release branch), but a quick fix seems to be this:
That works for me,
Thanks
Robert
--
^ permalink raw reply [flat|nested] 5+ messages in thread* bug#72077: 30.0.60; customizing which-key-dont-use-unicode to nil results in nil which-key-separator
2024-07-15 7:25 ` Robert Pluim
@ 2024-07-26 21:27 ` Philip Kaludercic
0 siblings, 0 replies; 5+ messages in thread
From: Philip Kaludercic @ 2024-07-26 21:27 UTC (permalink / raw)
To: Robert Pluim; +Cc: 72077-done, Eli Zaretskii, Justin Burkett
Robert Pluim <rpluim@gmail.com> writes:
>>>>>> On Sat, 13 Jul 2024 12:48:36 +0000, Philip Kaludercic
> <philipk@posteo.net> said:
> Philip> The issue here seems to be that
> Philip> `custom-reevaluate-setting' always sets
> Philip> a value, even if there is no `standard-value' associated
> Philip> with a user
> Philip> option. I don't know if we want to change that (certainly
> Philip> not on the
> Philip> release branch), but a quick fix seems to be this:
>
> That works for me,
OK, I have pushed the change in 1ae2f004. Hopefully closing the report
for good this time.
> Thanks
>
> Robert
--
Philip Kaludercic on peregrine
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-07-26 21:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-12 14:31 bug#72077: 30.0.60; customizing which-key-dont-use-unicode to nil results in nil which-key-separator Robert Pluim
2024-07-13 12:12 ` Eli Zaretskii
2024-07-13 12:48 ` Philip Kaludercic
2024-07-15 7:25 ` Robert Pluim
2024-07-26 21:27 ` Philip Kaludercic
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).