From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72453: 29.4; "use-package" macro does not load all expected related files Date: Sun, 04 Aug 2024 11:14:33 +0300 Message-ID: <86o768so0m.fsf@gnu.org> References: <87plqp9slr.fsf@priss.frightenedpiglet.com> <86v80gucas.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22791"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72453@debbugs.gnu.org, derek_upham@mailfence.com To: John Wiegley , Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 04 10:16:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1saWPf-0005n5-3u for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Aug 2024 10:16:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1saWPE-00021t-QE; Sun, 04 Aug 2024 04:15:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1saWP1-00020x-Tc for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2024 04:15:45 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1saWOz-0007YX-MQ for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2024 04:15:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=B+1Rcw84KPnXx3GF6i6dERqUNd94LEcmmOVjXXXjR9k=; b=F2Hmlan0F6IQcUPbR/3mZxu0AnCvUwr+3k/GKRVffea9epbIgNEGOZYze55Rvmyy0OMLtBJaFCQB7Opa8ebH4wf14HNVjTdU7qo/IwzC62sYCRk5/WkPw1HY9xRKkoi2/Xa03bWIgc6iRvwZuZAe+L6ZZO98J+UW3KfKdHvv6lX80D1jLBzHwXTz3tp7KxQJQZ5PITU8Elsbk1xTHMJ7lEfhwyodYbF3vSrqAlFerl50Z/7ZrVnWd1d3VFztR/O9x+R3MfrmelcNoCV90sTC0+a6TmueaJlyP31F0sEjRxOe1Gl/us4HuwHfkyrPx+KnhQ555kwnQVtVmznqd9HslQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1saWPK-00065y-02 for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2024 04:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Aug 2024 08:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72453 X-GNU-PR-Package: emacs Original-Received: via spool by 72453-submit@debbugs.gnu.org id=B72453.172275930823251 (code B ref 72453); Sun, 04 Aug 2024 08:16:01 +0000 Original-Received: (at 72453) by debbugs.gnu.org; 4 Aug 2024 08:15:08 +0000 Original-Received: from localhost ([127.0.0.1]:55415 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saWOS-00062v-1X for submit@debbugs.gnu.org; Sun, 04 Aug 2024 04:15:08 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46118) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saWOP-000622-Jn; Sun, 04 Aug 2024 04:15:06 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1saWNy-0007GD-Ki; Sun, 04 Aug 2024 04:14:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=B+1Rcw84KPnXx3GF6i6dERqUNd94LEcmmOVjXXXjR9k=; b=p8cUzb6VGAkjfKUPIzwo K0+mxEn8wlvmamIStWXGGrzILIAHLSnFCeTNEmw0kiHqq/YPHYfl68adKtUnbefHW9TTDF4DpH0n7 khNLlq10gcgQtpILtwVCxCrJiKMVWu3+K0n1TdylBlgk0NRj4iN8jOOMPlettLcXv4GlIRFP4bhtx lvcbWyNAWzSLjw2AMtmPtBN4buEV2TuG1AlTimBv2sUKpfXHpEXXo/qr6YA3GW/LxPH33AYUWuc2E ItoiA90UuJIX+nFK2AWnHoKzYW/2CabHDlT64meMN+l4zZlpXNUy/JvruFQtcADit964c7TaeAqlg btMGVuaiAXIaDw==; In-Reply-To: (message from John Wiegley on Sat, 03 Aug 2024 23:01:04 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289725 Archived-At: merge 72453 72293 thanks > From: John Wiegley > Cc: Derek Upham , 72453@debbugs.gnu.org > Date: Sat, 03 Aug 2024 23:01:04 -0700 > > >>>>> Eli Zaretskii writes: > > >> Moving the "use-package" macro into the top-level "use-package" file should > >> fix the problem. The "use-package" file explicitly loads the other files, > >> which sets up all of the defaults. > > > John, any comments or suggestions? > > I didn’t write any of the :ensure logic, so I have no comments there, but the > suggestion above sounds like a sound and harmless one to me. Thanks, John. Stefan, would you please handle this? Moving use-package from use-package-core.el to use-package.el would probably mean much more massive load whenever the macro is used, and I wonder whether there's a more light-weight solution. If such a light-weight solution exists, I think we should install it on the emacs-30 release branch, but if the only reasonable solution is what the OP suggested, then I think it should go to master. Btw, I think this bug and bug#72293 are the same bug, so I'm merging them.