From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72426: 29.2.50; comint-pager doesn't affect async-shell-command Date: Tue, 06 Aug 2024 22:07:27 +0300 Message-ID: <86o765o4gg.fsf@gnu.org> References: <86sevmupgo.fsf@gnu.org> <86bk29vcof.fsf@gnu.org> <26b6e3e6-7eee-686d-013b-0fc02c4125fe@gmail.com> <8634nhps4t.fsf@gnu.org> <86v80do795.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14350"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jporterbugs@gmail.com, 72426@debbugs.gnu.org To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 06 21:08:58 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sbPYH-0003bX-Sd for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Aug 2024 21:08:58 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sbPY0-0003bJ-2W; Tue, 06 Aug 2024 15:08:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbPXy-0003ao-Gk for bug-gnu-emacs@gnu.org; Tue, 06 Aug 2024 15:08:38 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sbPXy-0003MV-5P for bug-gnu-emacs@gnu.org; Tue, 06 Aug 2024 15:08:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=YmwabjwbAJBG1xLHKSWXLja1yYGRFOYqwLDwT0yIWkI=; b=fZT/xhwx02aw1A5yGgJ480z60cQzozqye5c0TfmRcWbMZX5sWSGtYvntuBflWVW+Ub/DT5CAODt1Ch14faxHV+ZCWdQ1H1s7h2yuXxw/pBHA/JFPv3Bssn9miEd2vWdSJCdzhsjft5zcBvfQI0A7dEJ9Ca65s7EJwdHzqfBlZzLANmNRvTb7e4ZcE1kPZfB+s3gIcMjncSqHHrW4D+09kH9cTTc0JWSNmWnKOwQ+OLH5F03yoOhCQ0oZUGDr1iP5bJJOCXAn5pRmhvgheCgkVddCNZxm79hsNS7ZFkBoctjVDRqyO82MrIKTvyQySTNupST6e5ASXo4DY7fcsnyI0w==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sbPYM-00075m-8R for bug-gnu-emacs@gnu.org; Tue, 06 Aug 2024 15:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Aug 2024 19:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72426 X-GNU-PR-Package: emacs Original-Received: via spool by 72426-submit@debbugs.gnu.org id=B72426.172297128227175 (code B ref 72426); Tue, 06 Aug 2024 19:09:02 +0000 Original-Received: (at 72426) by debbugs.gnu.org; 6 Aug 2024 19:08:02 +0000 Original-Received: from localhost ([127.0.0.1]:33073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbPXN-000745-Ru for submit@debbugs.gnu.org; Tue, 06 Aug 2024 15:08:02 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbPXM-00073j-8J for 72426@debbugs.gnu.org; Tue, 06 Aug 2024 15:08:00 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbPWr-0003Dz-TP; Tue, 06 Aug 2024 15:07:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=YmwabjwbAJBG1xLHKSWXLja1yYGRFOYqwLDwT0yIWkI=; b=AIQ1WnLIVX/a 7CYgJNhWcuKD0Tu02+Rk3xJoEEXTborjvHvMo1ajeiiXaYKafi7Z1v387sO+SiXnnW1qj9mnAgGz5 zJmzgXDswEiHRC/5HF+5OIbc/ZRDkYU2r8IniWr+4asyDDmQxUxT2jFZqc8DUIPsWV9IzsB66Yr64 eY0HGLjLhxjP6DU5xeML9NLrvCHdFtt3NnRImAhS8sk6V7OfGTrQfR5zkzRMz15gOikeRStmVLezt CrjOhFR3drsOx6X8IGQtfGhhL64STzFH8Wosm1rW/C3MsC6nPW2UXVVjVtjxobpjSqxGc8OOhGPKr a792O20tdpCmhaRaMSrkPA==; In-Reply-To: (message from Spencer Baugh on Tue, 06 Aug 2024 14:49:45 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289859 Archived-At: > From: Spencer Baugh > Cc: jporterbugs@gmail.com, 72426@debbugs.gnu.org > Date: Tue, 06 Aug 2024 14:49:45 -0400 > > Eli Zaretskii writes: > > >> From: Spencer Baugh > >> Cc: jporterbugs@gmail.com, 72426@debbugs.gnu.org > >> Date: Tue, 06 Aug 2024 12:42:09 -0400 > >> > >> --- a/lisp/startup.el > >> +++ b/lisp/startup.el > >> @@ -854,6 +854,10 @@ normal-top-level > >> ;; We are careful to do it late (after term-setup-hook), although the > >> ;; new multi-tty code does not use $TERM any more there anyway. > >> (setenv "TERM" "dumb") > >> + ;; Likewise, subprocesses should not use a pager unless told > >> + ;; otherwise, since it generally won't work. > >> + (when (executable-find "cat") > >> + (setenv "PAGER" "cat")) > > > > We need to work on the comment, because it doesn't explain any of what > > it needs to. Worse, it says something very confusing and at least > > inaccurate. > > Could you just say what you'd prefer the comment to be? I'm not sure > what exactly you'd like it to explain. I don't have a clear enough idea; I hoped you did, since you initiated this change to begin with. I just know that the text you wrote cannot be it, because it didn't explain to me anything about the reasons we should be doing this. The comment should explain why PAGER=cat is a good idea to go with TERM=dumb, for example. Maybe begin by saying why Emacs needs to set the variable at all, why not leave it unset?