From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 72559@debbugs.gnu.org, pipcet@protonmail.com, yantar92@posteo.net
Subject: bug#72559: 31.0.50; profiler-report-write-profile produced unreadable data
Date: Sat, 17 Aug 2024 17:27:08 +0300 [thread overview]
Message-ID: <86o75r1ayr.fsf@gnu.org> (raw)
In-Reply-To: <jwved6n4540.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Sat, 17 Aug 2024 10:07:59 -0400)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: pipcet@protonmail.com, yantar92@posteo.net, 72559@debbugs.gnu.org
> Date: Sat, 17 Aug 2024 10:07:59 -0400
>
> > This seems to avoid errors, but I still see problems in the profile
> > read from a file, which is displayed like this:
> >
> > Samples % Function
> > 35 31% redisplay_internal (C function)
> > 28 25% + command-execute
> > 28 25% Automatic GC
> > 8 7% + #<string 540>
> > 7 6% + ...
> > 4 3% + #<string 54A>
> > 2 1% + #<string 57C>
> >
> > Those "<string XYZ>" thingies are actually written in the file as
> > "#<byte-code-function F85>" strings, and I suspect that they should
> > have been written as function objects, not as strings.
>
> I don't think we want to write them as function objects, because then
> we'll again bump into the problem that some function objects contain
> unprintable objects like buffers.
But Emacs 29 does succeed there, at least in my testing, including
when the profile shows byte-compiled functions. So how come Emacs 30
cannot?
> Better would be to print the "#<byte-code-function F85>" strings
> as-is instead of printing them as #<string 540>.
Again, Emacs 30 shows the functions called by such byte-compiled
functions.
next prev parent reply other threads:[~2024-08-17 14:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-10 12:41 bug#72559: 31.0.50; profiler-report-write-profile produced unreadable data Ihor Radchenko
2024-08-10 12:50 ` Eli Zaretskii
2024-08-10 13:05 ` Ihor Radchenko
2024-08-10 13:56 ` Pip Cet via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-10 14:09 ` Eli Zaretskii
2024-08-10 16:17 ` Eli Zaretskii
2024-08-14 12:21 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-14 12:41 ` Eli Zaretskii
2024-08-14 12:48 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-17 10:03 ` Eli Zaretskii
2024-08-17 14:07 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-17 14:27 ` Eli Zaretskii [this message]
2024-08-17 17:35 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-17 17:49 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86o75r1ayr.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=72559@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=pipcet@protonmail.com \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).