From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74556: 30.0.92; Package upgrade can fail and results in deleted package Date: Wed, 11 Dec 2024 05:30:10 +0200 Message-ID: <86o71i522l.fsf@gnu.org> References: <87plmgq55e.fsf@daniel-mendler.de> <87zflj62ai.fsf@posteo.net> <87v7w7617o.fsf@posteo.net> <86ttbfism4.fsf@gnu.org> <87v7vvz0ay.fsf@posteo.net> <87zfl3h93m.fsf@daniel-mendler.de> <87ldwnxppc.fsf@posteo.net> <87pllzp9q4.fsf@daniel-mendler.de> <87h67bxosg.fsf@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34376"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mail@daniel-mendler.de, 74556@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 11 04:33:35 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tLDTi-0008np-BE for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 11 Dec 2024 04:33:34 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tLDTF-0003cd-BU; Tue, 10 Dec 2024 22:33:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLDTC-0003c9-Q9 for bug-gnu-emacs@gnu.org; Tue, 10 Dec 2024 22:33:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tLDTC-0002rw-6v for bug-gnu-emacs@gnu.org; Tue, 10 Dec 2024 22:33:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=Rqjj+HqfFqRyeoMRps7idsNVzpsz7wDNqefStnshrew=; b=GKgPlAh2aU/JX9uV0OpoHWgSh5Csmr3rhdRowoHqwypbjIEQgDaJ546wGDLdHc2bu2yEQdIavowtSTWIpoglTSIJJN8i8TJjFQxJpYwKNr3RbwRpZdZqie2xWWiQs3XNXSzXc9tXjjVttXGN6otftmTnhLaM2CAk6fG6s7U4qEpIAfu33O3n7sX11as3xvTndiJZJg9eYizARM/iip7blAyZcy2h4Py+OMqhDfsS1t+2/RkTRQTvKqe0GE8QSwZJA9OTv23DLwsfY/dGNp/X4Lg3XlRnzkKV4j3TEMGNgrqJcaeQECOiZkPfnclYi9TCa5KyFuqbORfCURsAXQVCWA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tLDTB-0005e5-Kq for bug-gnu-emacs@gnu.org; Tue, 10 Dec 2024 22:33:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Dec 2024 03:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74556 X-GNU-PR-Package: emacs Original-Received: via spool by 74556-submit@debbugs.gnu.org id=B74556.173388798021693 (code B ref 74556); Wed, 11 Dec 2024 03:33:01 +0000 Original-Received: (at 74556) by debbugs.gnu.org; 11 Dec 2024 03:33:00 +0000 Original-Received: from localhost ([127.0.0.1]:60638 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLDT4-0005di-RR for submit@debbugs.gnu.org; Tue, 10 Dec 2024 22:33:00 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47036) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLDSz-0005dK-Gw for 74556@debbugs.gnu.org; Tue, 10 Dec 2024 22:32:53 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLDQl-0002Ub-Kb; Tue, 10 Dec 2024 22:30:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Rqjj+HqfFqRyeoMRps7idsNVzpsz7wDNqefStnshrew=; b=YQtdxzwsv+cy uPQ26WPEDlBe/z8iUVZRuFtkKE4cf+Onge4EPihGSzU2F4n82kOHiRr+OV+3MWr2hMyaGI9DPXF6m 53WU6mQ8s4BtEIc5cigSj7dg37faXU4gztNkQFdMDFVF0vov5KUxV1uVpLTBX6LswRMGQypS0Hyvn k8hPuzdWORIgEz3JrA/r35JSYbUHNYrZsYooCF//wXBoi9Px0Xt+RCaYdMl6cxvK8aTdX6/0iWRbI qUSHFi/L7gHEWwlv75rzQuIvCoxp4KY6VaKVW80jk2ckTUXfST2VHp1NAJ44uib5BDC2LRgtKZ6/1 AdlvqgPku3T+Q9yZNr6hfA==; In-Reply-To: <87h67bxosg.fsf@posteo.net> (message from Philip Kaludercic on Tue, 10 Dec 2024 20:31:59 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296793 Archived-At: > From: Philip Kaludercic > Cc: Eli Zaretskii , 74556@debbugs.gnu.org > Date: Tue, 10 Dec 2024 20:31:59 +0000 > > Daniel Mendler > Philip Kaludercic writes: > > > >> Daniel Mendler writes: > >> > >>> Philip Kaludercic writes: > >>> > >>>> Eli Zaretskii writes: > >>>> > >>>>>> Cc: 74556@debbugs.gnu.org > >>>>>> From: Philip Kaludercic > >>>>>> Date: Thu, 28 Nov 2024 11:34:51 +0000 > >>>>>> > >>>>>> Philip Kaludercic writes: > >>>>>> > >>>>>> [...] > >>>>>> > >>>>>> > It might make sense to try and "deactivate" a package before installing > >>>>>> > the new package. Looking into some second-try fallback for > >>>>>> > package-install to refresh the package index if a package was not found > >>>>>> > would also be a good idea ^^ > >>>>>> > >>>>>> This might do it? > >>>>> > >>>>> Philip, please install this on the emacs-30 branch, unless you see any > >>>>> problems with the change. We'd like to make another pretest soon. > >>>> > >>>> Done. But we should keep the report open as there might be better > >>>> approaches to discuss in the future. > >>> > >>> Hello Philip, > >>> > >>> I just tried the modified `package-upgrade' function and it doesn't seem > >>> to work. It seems to break the upgrade procedure in an even worse way, > >>> at least in my setup. Now `package-install' is tried first with the > >>> package symbol, which will be a no-op, since the package is already > >>> installed. Afterwards the package is deleted and we always end up with > >>> no package. Probably `package-install' should also be called with a > >>> package descriptor of the new package version? > >> > >> Right, my sincere apologies for that oversight. That being said, I > >> don't feel comfortable fixing this right now as I am short on time to > >> fix and test something like this on the "emacs-30" branch. My vote > >> would be to revert the commit and try to tackle the issue on the > >> "master" branch. An alternative I can propose that would be closer to > >> the original code might be > > > > Yes, I also vote to revert your commit on the emacs-30 release branch. > > The issue isn't severe (and not a regression), so I'd say it is okay to > > fix the issue on the master branch. > > Eli, what do you say? It looks like you are in agreement, so please revert on emacs-30. (Unless you also want to revert on master, don't forget to say "do not merge" in the log message.) Thanks.