From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#75192: [PATCH] Update fontification for attribute values in heex-ts-mode Date: Thu, 02 Jan 2025 17:24:53 +0200 Message-ID: <86o70pjl16.fsf@gnu.org> References: <86zfk9k3xr.fsf@gnu.org> <86ttahk2j2.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39787"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, 75192@debbugs.gnu.org, stefankangas@gmail.com To: Wilhelm Kirschbaum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 02 16:26:22 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tTN5Y-000A9z-Ao for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Jan 2025 16:26:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tTN5J-0007hR-Vx; Thu, 02 Jan 2025 10:26:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTN5H-0007go-26 for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2025 10:26:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tTN5G-0000Z9-Pr for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2025 10:26:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=fDghuEAYXMBHiwFqnk7OUIbVME5DRo6AzN3tGRqbNZU=; b=X5s8ziSsOUafT/qjoxegj/nYSXs/5z5BgrxBWpQqCLwAiLBQHFH9R89XroouPM0BGLuHj/SaPGrM2OpUTuEOiEWTSONiGkoFTJND2vnaQrphY5243NxYKXhXjAAwxiX71AheN0dekJFrjyGOnKHQ9mswozJ8CtkH79KJkHvlhOX3csY3kFRROo742yZZWLKec+dj+UWhXO6pVvUalbsb3PbPYHh6aKCz9PhghaC4qAv4XgjMjdjtpSrLokWLG5u8RiFzXEpnLqOoJY9fch4+mnmCpbTTOxLZolsY6QCfB5xAqKmvXL+4MGQhqTLcujDg9tbzc6wt2SNVI2dpHWGsHQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tTN5G-0006pe-4H for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2025 10:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Jan 2025 15:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75192 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 75192-submit@debbugs.gnu.org id=B75192.173583152026182 (code B ref 75192); Thu, 02 Jan 2025 15:26:02 +0000 Original-Received: (at 75192) by debbugs.gnu.org; 2 Jan 2025 15:25:20 +0000 Original-Received: from localhost ([127.0.0.1]:46132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tTN4a-0006oD-Df for submit@debbugs.gnu.org; Thu, 02 Jan 2025 10:25:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53480) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tTN4Z-0006kW-AF for 75192@debbugs.gnu.org; Thu, 02 Jan 2025 10:25:19 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTN4T-0000Uj-QY; Thu, 02 Jan 2025 10:25:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=fDghuEAYXMBHiwFqnk7OUIbVME5DRo6AzN3tGRqbNZU=; b=XdUZG0bLW49r HScRjWjId0yq7rBqf2G3GOz4ltk3hLjdq5ZP2K7sEZAz2eV5v+gtrADo+Of2SSwOeGEnx3dcBwu9s alFhCdKqhToj2o9G6OPn/AJtPZu3MOpxl8qDbi1Q0PgmSNIJ7i7aMsXH1Cp2CIT8i/bI97ar+Yaob dHi/SzWlnKmVLYkGhhzkXboNfeIIi43onoQ9Tivmz8Sbp2F3WtySLMD1kT0wLFwCd95+CM24vwpTN G/TKqMTnUzNIcguDui7rC1kiUbIJonN79oegX2KNHJiRjdPIxOdfL0joDbjOFj7aLrsijQBierGOt fnsJk1IKELlTVZnfK2rORw==; In-Reply-To: (message from Wilhelm Kirschbaum on Thu, 2 Jan 2025 12:13:27 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298176 Archived-At: > From: Wilhelm Kirschbaum > Date: Thu, 2 Jan 2025 12:13:27 +0200 > Cc: Stefan Kangas , 75192@debbugs.gnu.org, casouri@gmail.com > > > > attribute be highlighted as a string? > > > > I'm not familiar with HEEx and can't share a useful opinion, but FWIW, I > > simply noted that the code directly above the change said > > > > :feature 'heex-string > > > > which is why I assumed that using a string face should make sense. > > So we think that the current face is just a typo? > > Originally I was not sure what would be more appropriate, but got a comment from a user and saw > html-ts-mode uses string so thought it would be good to change before it gets released. OK, then I think installing this on emacs-30 is TRT.