From: Eli Zaretskii <eliz@gnu.org>
To: Wilhelm Kirschbaum <wkirschbaum@gmail.com>
Cc: casouri@gmail.com, 75192@debbugs.gnu.org, stefankangas@gmail.com
Subject: bug#75192: [PATCH] Update fontification for attribute values in heex-ts-mode
Date: Thu, 02 Jan 2025 17:24:53 +0200 [thread overview]
Message-ID: <86o70pjl16.fsf@gnu.org> (raw)
In-Reply-To: <CAOS0-35Zvj8v6URG8TnvWEYDaD8eXR6X9Waz0wsPkRbDWjnwiA@mail.gmail.com> (message from Wilhelm Kirschbaum on Thu, 2 Jan 2025 12:13:27 +0200)
> From: Wilhelm Kirschbaum <wkirschbaum@gmail.com>
> Date: Thu, 2 Jan 2025 12:13:27 +0200
> Cc: Stefan Kangas <stefankangas@gmail.com>, 75192@debbugs.gnu.org, casouri@gmail.com
>
> > > attribute be highlighted as a string?
> >
> > I'm not familiar with HEEx and can't share a useful opinion, but FWIW, I
> > simply noted that the code directly above the change said
> >
> > :feature 'heex-string
> >
> > which is why I assumed that using a string face should make sense.
>
> So we think that the current face is just a typo?
>
> Originally I was not sure what would be more appropriate, but got a comment from a user and saw
> html-ts-mode uses string so thought it would be good to change before it gets released.
OK, then I think installing this on emacs-30 is TRT.
next prev parent reply other threads:[~2025-01-02 15:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-30 10:59 bug#75192: [PATCH] Update fontification for attribute values in heex-ts-mode Wilhelm Kirschbaum
2025-01-02 7:45 ` Stefan Kangas
2025-01-02 8:36 ` Eli Zaretskii
2025-01-02 8:41 ` Stefan Kangas
2025-01-02 8:56 ` Wilhelm Kirschbaum
2025-01-02 9:06 ` Eli Zaretskii
2025-01-02 10:13 ` Wilhelm Kirschbaum
2025-01-02 15:24 ` Eli Zaretskii [this message]
2025-01-03 5:49 ` Yuan Fu
2025-01-03 15:14 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86o70pjl16.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=75192@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=stefankangas@gmail.com \
--cc=wkirschbaum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).