From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.bugs Subject: bug#32463: 27.0.50; (logior -1) => 4611686018427387903 Date: Sun, 19 Aug 2018 19:00:43 +0100 Message-ID: <86mutinsms.fsf@gmail.com> References: <5230a57b-5896-606d-f157-2e547710b6e8@cs.ucla.edu> <66c3b06d-bf67-8f61-4b13-1debf0668010@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1534701616 2153 195.159.176.226 (19 Aug 2018 18:00:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 19 Aug 2018 18:00:16 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (windows-nt) To: 32463@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 19 20:00:12 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frRzn-0000Qn-BV for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 Aug 2018 20:00:11 +0200 Original-Received: from localhost ([::1]:43719 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frS1s-0003h2-95 for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 Aug 2018 14:02:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49755) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frS1e-0003gv-Gs for bug-gnu-emacs@gnu.org; Sun, 19 Aug 2018 14:02:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1frS1a-00054z-Ew for bug-gnu-emacs@gnu.org; Sun, 19 Aug 2018 14:02:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49781) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1frS1a-00054t-CJ for bug-gnu-emacs@gnu.org; Sun, 19 Aug 2018 14:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1frS1a-0006lk-7G for bug-gnu-emacs@gnu.org; Sun, 19 Aug 2018 14:02:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Andy Moreton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Aug 2018 18:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32463 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.153470166525954 (code B ref -1); Sun, 19 Aug 2018 18:02:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 19 Aug 2018 18:01:05 +0000 Original-Received: from localhost ([127.0.0.1]:54799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frS0f-0006kY-Ie for submit@debbugs.gnu.org; Sun, 19 Aug 2018 14:01:05 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frS0e-0006jy-Sc for submit@debbugs.gnu.org; Sun, 19 Aug 2018 14:01:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1frS0Y-00046R-UA for submit@debbugs.gnu.org; Sun, 19 Aug 2018 14:00:59 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:56598) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1frS0Y-00046F-RK for submit@debbugs.gnu.org; Sun, 19 Aug 2018 14:00:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49552) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frS0X-0003Wv-Un for bug-gnu-emacs@gnu.org; Sun, 19 Aug 2018 14:00:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1frS0U-000412-0A for bug-gnu-emacs@gnu.org; Sun, 19 Aug 2018 14:00:57 -0400 Original-Received: from [195.159.176.226] (port=50238 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1frS0T-00040c-Q3 for bug-gnu-emacs@gnu.org; Sun, 19 Aug 2018 14:00:53 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1frRyK-00074V-Al for bug-gnu-emacs@gnu.org; Sun, 19 Aug 2018 19:58:40 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 39 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:2rTyS6QMXzRkrTqWpYcFTvZmato= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149598 Archived-At: On Sun 19 Aug 2018, Paul Eggert wrote: >>> a) A bug in bignumcompare for 64bit Windows. Patch is here: >>> http://lists.gnu.org/archive/html/emacs-devel/2018-08/msg00487.html >>> ... >>> b) fmod_float has a bug: >>> http://lists.gnu.org/archive/html/emacs-devel/2018-08/msg00442.html >>> >>> c) Extend Fexpt to support bignums. Patch is here: >>> http://lists.gnu.org/archive/html/emacs-devel/2018-08/msg00503.html >>> >>> d) Extend Fceiling, Ffloor, Fround and Ftruncate to support bignums by >>>    updating rounding_driver. > > I worked on these and installed patches to master that should do (a), (b), and > (c). For (d) I wrote the attached patch, and plan to test it a bit more before > installing, as it's the hairiest. Thanks for fixing up all of these issues. Hopefully with some added test cases the patch for (d) will also work too. Two more issues: e) Grepping for FIXED_OR_FLOATP shows various places where code either assumes that all types are covered (no longer true now there are bignums), or uses incorrect accessors for the value in the object. For example, Fdefine_coding_system_internal has: else if (FIXED_OR_FLOATP (tmp)) { dim2 = CHARSET_DIMENSION (CHARSET_FROM_ID (XFIXNAT (tmp))); Which should probably be: else if (NUMBERP (tmp)) { dim2 = CHARSET_DIMENSION (CHARSET_FROM_ID (XFLOATINT (tmp))); f) Users of CONS_TO_INTEGER and INTEGER_TO_CONS could be converted to use bignums.