From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Newsgroups: gmane.emacs.bugs Subject: bug#51037: [PATCH] Make `print-level` & `print-length` customizable in ERT batch tests Date: Sat, 20 Nov 2021 08:49:05 -0800 Message-ID: <86mtlylqm6.fsf@pobox.com> References: <86tuhvmtpl.fsf@runbox.com> <87ily94662.fsf@gnus.org> <83fstd1bth.fsf@gnu.org> <87czogslm4.fsf@gnus.org> <86ily2mjtq.fsf@runbox.com> <87r1cp89o4.fsf@gnus.org> <86fst5m48v.fsf@runbox.com> <87a6jd5891.fsf@gnus.org> <86mtmykxro.fsf@runbox.com> <87y26hz24c.fsf@gnus.org> <86bl3blcgm.fsf@runbox.com> <87wnlya9sj.fsf@gnus.org> <86wnlbmooj.fsf@runbox.com> <87fsry7qdy.fsf@gnus.org> <87bl2m7q9g.fsf@gnus.org> <86zgq5kn9y.fsf@runbox.com> <87ilws7d7e.fsf@gnus.org> <87pmqxlsob.fsf@gnus.org> <86pmqwkw1r.fsf@pobox.com> Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10817"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.4.15; emacs 28.0.50 Cc: gazally@runbox.com, Lars Ingebrigtsen , 51037@debbugs.gnu.org To: Filipp Gunbin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 20 17:50:21 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1moTZE-0002c6-MK for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 20 Nov 2021 17:50:20 +0100 Original-Received: from localhost ([::1]:36642 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1moTZC-0005jh-Pc for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 20 Nov 2021 11:50:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56056) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moTYx-0005jI-11 for bug-gnu-emacs@gnu.org; Sat, 20 Nov 2021 11:50:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60257) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1moTYw-0004fk-Ns for bug-gnu-emacs@gnu.org; Sat, 20 Nov 2021 11:50:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1moTYw-0003T9-K7 for bug-gnu-emacs@gnu.org; Sat, 20 Nov 2021 11:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 20 Nov 2021 16:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51037 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51037-submit@debbugs.gnu.org id=B51037.163742698013290 (code B ref 51037); Sat, 20 Nov 2021 16:50:02 +0000 Original-Received: (at 51037) by debbugs.gnu.org; 20 Nov 2021 16:49:40 +0000 Original-Received: from localhost ([127.0.0.1]:43570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moTYa-0003SH-Fq for submit@debbugs.gnu.org; Sat, 20 Nov 2021 11:49:40 -0500 Original-Received: from transit01.runbox.com ([91.220.196.211]:59388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moTYX-0003S1-Vf for 51037@debbugs.gnu.org; Sat, 20 Nov 2021 11:49:39 -0500 Original-Received: from mailtransmit03.runbox ([10.9.9.163] helo=aibo.runbox.com) by transit01.runbox.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1moTYR-004PZf-B0; Sat, 20 Nov 2021 17:49:31 +0100 Original-Received: from [10.9.9.72] (helo=submission01.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1moTYO-0004cV-4P; Sat, 20 Nov 2021 17:49:28 +0100 Original-Received: by submission01.runbox with esmtpsa [Authenticated ID (942723)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1moTY5-0002ng-Ik; Sat, 20 Nov 2021 17:49:09 +0100 In-reply-to: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220510 Archived-At: > On 19/11/2021 07:24 -0800, Michael wrote: > >> Lars Ingebrigtsen writes: >> >>> Filipp Gunbin writes: >>> >>>> The docstring for backtrace-line-length says: "If set to nil >>>> or >>>> zero, >>>> backtrace mode will not abbreviate the forms it prints." So >>>> the >>>> above >>>> sentence, which I removed, was indeed not true? (a quick >>>> look over >>>> its usages confirmed that to me, but I'd like someone else to >>>> check) >>> >>> I think the intention is that a nil value of >>> backtrace-line-length >>> shouldn't limit the lengths -- but I haven't tested it. >>> Doesn't it >>> work? >> >> Yes, I'm a bit lost, Filipp... what is your concern? And I >> thought I *had* tested that. > > That the docstring contained a sentence which is not true. A > minor > issue, of course. I give examples here: > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=51037#117 > > (there was also fix of interactive spec of > `ert-run-tests-interactively', > but that's obvious I think) > Hey Filipp, Note that _is_ true, as far as I know, and was intended to be true before my patch, and I verified that it became true with my patch :) Can you provide a test case that demonstrates it to be not true? -- Michael