From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#52973: Adding a few context-menu-mode commands Date: Mon, 03 Jan 2022 23:17:18 +0200 Organization: LINKOV.NET Message-ID: <86mtkcr02p.fsf@mail.linkov.net> References: <87o84tp69h.fsf@posteo.net> <83pmp9c7j9.fsf@gnu.org> <877dbhoril.fsf@posteo.net> <837dbgdh51.fsf@gnu.org> <871r1opwbi.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4916"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 52973@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 03 22:23:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n4UnT-00018H-SE for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 Jan 2022 22:23:15 +0100 Original-Received: from localhost ([::1]:40404 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n4UnS-0002Js-QR for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 Jan 2022 16:23:14 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56374) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n4UlL-0007Tv-9A for bug-gnu-emacs@gnu.org; Mon, 03 Jan 2022 16:21:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53100) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n4UlK-0003ih-Vp for bug-gnu-emacs@gnu.org; Mon, 03 Jan 2022 16:21:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n4UlK-00007h-T3 for bug-gnu-emacs@gnu.org; Mon, 03 Jan 2022 16:21:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Jan 2022 21:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52973 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52973-submit@debbugs.gnu.org id=B52973.1641244834397 (code B ref 52973); Mon, 03 Jan 2022 21:21:02 +0000 Original-Received: (at 52973) by debbugs.gnu.org; 3 Jan 2022 21:20:34 +0000 Original-Received: from localhost ([127.0.0.1]:36412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4Uks-00006G-B3 for submit@debbugs.gnu.org; Mon, 03 Jan 2022 16:20:34 -0500 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]:54313) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4Ukf-00005j-Vu for 52973@debbugs.gnu.org; Mon, 03 Jan 2022 16:20:22 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id BDF361BF20B; Mon, 3 Jan 2022 21:20:14 +0000 (UTC) In-Reply-To: <871r1opwbi.fsf@posteo.net> (Philip Kaludercic's message of "Mon, 03 Jan 2022 17:23:45 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223610 Archived-At: >>> > Maybe I'm missing something, but I don't see the actual integration >>> > with context-menu-mode? >>> >>> Each commit adds a function that can be added to context-menu-functions. >> >> That was my guess, but without having those additions, not even as a >> user option, or (better) automagically when context-menu-mode is >> turned on, those functions are just dead ballast, aren't they? > > From my understanding of bug#50552, this was preferred. bug#50552 proposed to add to every package such lines: (custom-add-choice 'context-menu-functions '(function-item :tag "Dictionary menu" context-menu-dictionary)) but 'custom-add-choice' fails on the current structure of 'context-menu-functions', so either a new function 'custom-add-repeat-choice' should be created, or better would be to improve the existing 'custom-add-choice' to handle the choices inside 'repeat'.