unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: sbaugh@catern.com, Eli Zaretskii <eliz@gnu.org>, 66317@debbugs.gnu.org
Subject: bug#66317: Project mode-line
Date: Thu, 19 Oct 2023 09:40:23 +0300	[thread overview]
Message-ID: <86mswfxgh6.fsf@mail.linkov.net> (raw)
In-Reply-To: <86e34144-5ac6-2819-b242-fa9bc8fef098@gutov.dev> (Dmitry Gutov's message of "Wed, 18 Oct 2023 21:41:53 +0300")

> FWIW, I haven't been able to reproduce this so far.

Unfortunately it's not easily reproducible.

>> The bug occurs when multiple lines are displayed in the echo area.
>> Then '(:eval (project-mode-line-format)) is called twice.
>> At the end of the first call 'buffer-file-coding-system'
>> is still correct: utf-8.  But at the beginning of the
>> second call it's already wrong: raw-text.
>>
>> I guess it was a mistake to allow specifying the project name
>> in .dir-locals.el.  A better place would be in ~/.emacs.d/projects.
>
> But project-name uses project--value-in-dir which uses a temporary buffer
> to apply all variables in.

So it does this extensive work several times per second every time
when the mode-line is updated?

Then maybe better to cache the project name somewhere? 

> Does that affect the original buffer somehow?

Actually it doesn't affect the original buffer directly.
When saving a buffer and the message is multi-line
during saving, then '(project-mode-line-format)' is called twice,
and the buffer coding is changed between these calls.

I don't know where is this code that decides to evaluate
mode-line-format twice in a row, and how this code is affected
by temporary buffers used by project--value-in-dir.





  reply	other threads:[~2023-10-19  6:40 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-03  6:29 bug#66317: Project mode-line Juri Linkov
2023-10-03  8:07 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-03 16:24   ` Dmitry Gutov
2023-10-03 17:11   ` Juri Linkov
2023-10-03 17:51     ` Dmitry Gutov
2023-10-03 17:58       ` Juri Linkov
2023-10-03 18:04         ` Dmitry Gutov
2023-10-03 18:17         ` Eli Zaretskii
2023-10-04  6:18           ` Juri Linkov
2023-10-04  7:15             ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-04 17:06               ` Juri Linkov
2023-10-05 20:03                 ` Spencer Baugh
2023-10-05 20:16                   ` Dmitry Gutov
2023-10-06  6:46                   ` Juri Linkov
2023-10-09 18:45                 ` Juri Linkov
2023-10-09 18:57                   ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-10  6:56                     ` Juri Linkov
2023-10-10 11:46                       ` Dmitry Gutov
2023-10-11  6:27                         ` Juri Linkov
2023-10-04  7:43             ` Eli Zaretskii
2023-10-04 14:34               ` Dmitry Gutov
2023-10-04 17:04               ` Juri Linkov
2023-10-05 20:23             ` Dmitry Gutov
2023-10-06  4:50               ` Eli Zaretskii
2023-10-06  6:44                 ` Juri Linkov
2023-10-06 10:20                   ` Dmitry Gutov
2023-10-09 18:10                     ` Juri Linkov
2023-10-09 18:22                       ` Dmitry Gutov
2023-10-09 18:48                         ` Juri Linkov
2023-10-09 18:52                           ` Dmitry Gutov
2023-10-10  6:50                             ` Juri Linkov
2023-10-10  7:10                               ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-10  7:18                                 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-10 10:45                                 ` Dmitry Gutov
2023-10-10 11:34                                   ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-10 11:42                                     ` Dmitry Gutov
2023-10-20  9:01             ` Ihor Radchenko
2023-10-20 15:52               ` Dmitry Gutov
2023-10-31  7:34                 ` Juri Linkov
2023-11-01  2:03                   ` Dmitry Gutov
2023-11-01  7:32                     ` Juri Linkov
2023-10-03 12:06 ` Stefan Kangas
2023-10-15 22:42 ` sbaugh
2023-10-16  0:57   ` Dmitry Gutov
2023-10-16 17:01     ` Juri Linkov
2023-10-16 19:12       ` Eli Zaretskii
2023-10-18 17:20         ` Juri Linkov
2023-10-18 18:41           ` Dmitry Gutov
2023-10-19  6:40             ` Juri Linkov [this message]
2023-10-19 11:23               ` Dmitry Gutov
2023-10-23 17:23                 ` Juri Linkov
2023-10-24 23:48                   ` Dmitry Gutov
2023-10-18 18:55       ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86mswfxgh6.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=66317@debbugs.gnu.org \
    --cc=dmitry@gutov.dev \
    --cc=eliz@gnu.org \
    --cc=sbaugh@catern.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).