From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#63648: 29.0.90; project.el: with switch-use-entire-map, switch-project errors on non-project commands Date: Mon, 23 Oct 2023 09:58:00 +0300 Organization: LINKOV.NET Message-ID: <86msw9g5yb.fsf@mail.linkov.net> References: <8634zyjt0k.fsf@mail.linkov.net> <8d1fb7ac-5c82-0ec2-8ae2-d09c131ec165@gutov.dev> <86edj6hyem.fsf@mail.linkov.net> <8634zitwoy.fsf@mail.linkov.net> <50d46d30-a796-b855-0d4c-690d6cb3d15b@gutov.dev> <86il88x9cy.fsf@mail.linkov.net> <4367c45c-95b3-6a29-4ba3-068a3c748452@gutov.dev> <2e34e515-a921-a969-0915-bea94c745f8b@gutov.dev> <868r9258oi.fsf@mail.linkov.net> <86edishisp.fsf@mail.linkov.net> <6fc81cbf-a21f-c5b4-aa56-e8518b8570d7@gutov.dev> <86msxgatuy.fsf@mail.linkov.net> <86y1gynr2u.fsf@mail.linkov.net> <7c72fd8c-c3f6-a974-8a4b-a081f7a9fe1a@gutov.dev> <86ttqmv7c6.fsf@mail.linkov.net> <56e7d865-0456-db7d-3a5d-1235e62508bf@gutov.dev> <865y31onju.fsf@mail.linkov.net> <8562bdad-e487-886a-af49-7f67d8d14b7a@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12711"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Spencer Baugh , 63648@debbugs.gnu.org, sbaugh@catern.com To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 23 09:23:48 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qupHw-0003BS-4S for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 23 Oct 2023 09:23:48 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qupHk-0001kH-5p; Mon, 23 Oct 2023 03:23:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qupHh-0001j4-Lz for bug-gnu-emacs@gnu.org; Mon, 23 Oct 2023 03:23:33 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qupHh-0007YV-Ds for bug-gnu-emacs@gnu.org; Mon, 23 Oct 2023 03:23:33 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qupIA-0000R2-81 for bug-gnu-emacs@gnu.org; Mon, 23 Oct 2023 03:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Oct 2023 07:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63648 X-GNU-PR-Package: emacs Original-Received: via spool by 63648-submit@debbugs.gnu.org id=B63648.16980457931596 (code B ref 63648); Mon, 23 Oct 2023 07:24:02 +0000 Original-Received: (at 63648) by debbugs.gnu.org; 23 Oct 2023 07:23:13 +0000 Original-Received: from localhost ([127.0.0.1]:48937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qupHN-0000Pg-2N for submit@debbugs.gnu.org; Mon, 23 Oct 2023 03:23:13 -0400 Original-Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]:41905) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qupHK-0000PQ-MG for 63648@debbugs.gnu.org; Mon, 23 Oct 2023 03:23:11 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id BAA211C0003; Mon, 23 Oct 2023 07:22:33 +0000 (UTC) In-Reply-To: <8562bdad-e487-886a-af49-7f67d8d14b7a@gutov.dev> (Dmitry Gutov's message of "Fri, 20 Oct 2023 22:25:06 +0300") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273009 Archived-At: >> Wow, it works nicely for 'C-x p p C-x d'. >> But strange it fails for 'C-x p p C-x v d' >> with the same error: >> (wrong-type-argument commandp 1) > > That's because (lookup-key ... "vd") also returns 1. > > I haven't been able to find a solution that works like we would expect. The > most trivial would be to loop cutting off invalid prefixes, but then we end > up with 'd', not 'v'. That's probably not what you want. > > Ideally, 'read-key-sequence' would stop at the user pressing 'v' and return > "^Xv", then the rest would work out okay. But I haven't managed to have it > do that, even when using overriding-terminal-local-map and temporarily > altering the global map. My experimental patch is below, you can try > tweaking it. Now can't type 'C-x p p C-x v d' completely because 'C-x p p C-x v' opens vc-dir after typing 'v'. > And overall I'm not sure it's a constructive approach because you might > have been going for 'C-x v d' (where the 'v' translation is correct), but > you might have been going for 'C-x v D' or 'C-x v v' instead, very > different commands. It might be better to report unknown key sequence and > let the user make an explicit choice, like it works now. Depends on whether > you notice the key sequence echoing while doing that input. Maybe adding a new option 'project-switch-use-global-map' would help?