From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68810: 29.1; Recommending setting transfer.fsckObjects of git to true is not necessary Date: Tue, 30 Jan 2024 14:27:07 +0200 Message-ID: <86mssn2ehw.fsf@gnu.org> References: <87a5onlnwk.fsf@linj.tech> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11344"; mail-complaints-to="usenet@ciao.gmane.io" Cc: me@linj.tech, 68810@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 30 13:28:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rUnDt-0002k8-Ni for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 30 Jan 2024 13:28:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rUnDY-0004Jj-ON; Tue, 30 Jan 2024 07:27:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUnDV-0004GZ-Dq for bug-gnu-emacs@gnu.org; Tue, 30 Jan 2024 07:27:53 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rUnDV-000062-1u for bug-gnu-emacs@gnu.org; Tue, 30 Jan 2024 07:27:53 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rUnDd-0007vN-Lq for bug-gnu-emacs@gnu.org; Tue, 30 Jan 2024 07:28:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Jan 2024 12:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68810 X-GNU-PR-Package: emacs Original-Received: via spool by 68810-submit@debbugs.gnu.org id=B68810.170661767230445 (code B ref 68810); Tue, 30 Jan 2024 12:28:01 +0000 Original-Received: (at 68810) by debbugs.gnu.org; 30 Jan 2024 12:27:52 +0000 Original-Received: from localhost ([127.0.0.1]:34530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUnDT-0007uy-Dx for submit@debbugs.gnu.org; Tue, 30 Jan 2024 07:27:51 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUnDQ-0007uj-RH for 68810@debbugs.gnu.org; Tue, 30 Jan 2024 07:27:49 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUnDC-0008Sf-8R; Tue, 30 Jan 2024 07:27:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=fh3jf72NKxkSrp7bo2/e0Q8Es17dHugHwB2XgcnWtKo=; b=IXz4aODybRBv YeJlbb+aPtqn6lmRyDsKSFhvEbu1s7xOLG3IgS3tUj4SRAuLyHK3GQrKNd60wA6LU8DxsjDnARsdF /jVKkxjOIEY2YpogsAE3NshRXMH1LlEl1+zzSna6WZSAMC1De5PZIM0M2PiyPd5H7UAbZ91eEovUe 9sij9Csq+uLMqMzwSxUHXayQKrpIeC5INhOQVSL2KW8wzFIXS7C5LFMbln2wdD6Pu4/R4Lb/zog1T IHEPp3oGkpZ1fpoCgU59x4pBYbsb0YLlvJ4tJsdu0b4MOnuUN1E4URCsB+m1teajgy3Vb/TXulTWX lEaf2C2ZiSDfwGmEvrEQhw==; In-Reply-To: (message from Stefan Kangas on Mon, 29 Jan 2024 19:39:54 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279170 Archived-At: > From: Stefan Kangas > Date: Mon, 29 Jan 2024 19:39:54 -0500 > > Lin Jian via "Bug reports for GNU Emacs, the Swiss army knife of text > editors" writes: > > > Recommendation about setting transfer.fsckObjects of git to true can be > > found in admin/notes/git-workflow and CONTRIBUTE. In addition, it is > > set in autogen.sh. > > > > This is triggered by a discussion[1] on emacs-devel. The first commit > > about this is cedd7cad092809a97c1ed7fb883b68fa844cea58 on 2016-01-31. > > However, on 2016-02-04, another discussion[2] shows that git is secure > > by default so setting this option is not necessary. > > > > What about removing this unnecessary recommendation? > > > > By the way, the same recommendation can be found on Emacswiki[3][4]. > > > > [1]: https://lists.gnu.org/r/emacs-devel/2016-01/msg01802.html > > [2]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813157#29 > > [3]: https://www.emacswiki.org/emacs/GitQuickStartForEmacsDevs > > [4]: https://www.emacswiki.org/emacs/GitForEmacsDevs > > Are you sure? The git documentation says: > > transfer.fsckObjects > > When fetch.fsckObjects or receive.fsckObjects are not set, the value > of this variable is used instead. Defaults to false. > > When set, the fetch or receive will abort in the case of a malformed > object or a link to a nonexistent object. In addition, various other > issues are checked for, including legacy issues (see fsck.), > and potential security issues like the existence of a .GIT directory > or a malicious .gitmodules file (see the release notes for v2.2.1 > and v2.17.1 for details). Other sanity and security checks may be > added in future releases. > > https://git-scm.com/docs/git-config#Documentation/git-config.txt-transferfsckObjects And I have another question: does this setting cause any harm, or can cause any harm in some situations? IOW, what are the downsides of using this setting?