From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70361: [PATCH] Add font-locking for operators in go-ts-mode. Date: Sat, 13 Apr 2024 10:40:09 +0300 Message-ID: <86mspxr9ra.fsf@gnu.org> References: <86r0f9ranr.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1040"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70361@debbugs.gnu.org To: Noah Peart , Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 13 09:41:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rvY0g-000Ad9-5R for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Apr 2024 09:41:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rvY0S-0001Xi-En; Sat, 13 Apr 2024 03:41:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rvY0M-0001Vh-JJ for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2024 03:40:54 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rvY0L-00030W-27 for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2024 03:40:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rvY0V-000455-BB for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2024 03:41:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Apr 2024 07:41:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70361 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70361-submit@debbugs.gnu.org id=B70361.171299403815488 (code B ref 70361); Sat, 13 Apr 2024 07:41:03 +0000 Original-Received: (at 70361) by debbugs.gnu.org; 13 Apr 2024 07:40:38 +0000 Original-Received: from localhost ([127.0.0.1]:59988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvY05-00041i-Kl for submit@debbugs.gnu.org; Sat, 13 Apr 2024 03:40:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvY02-00040N-Re for 70361@debbugs.gnu.org; Sat, 13 Apr 2024 03:40:35 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rvXzn-0002t8-4o; Sat, 13 Apr 2024 03:40:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=KRvwhjkrNlA0aT6vrNpksgDsyXSrSHc99qR8PZriLnc=; b=fSNM7QUgW1hs gU8F2gZRmBEjDtic4WJPp9xIR3sq3DHkcUKXsrnU7/weJs7Rf9k6qmsvinISWHQpzcRb4A3lMk6au EaQdAAgKIFSuqIp5IJYoR60B/sH7s84K9frKAFiQxCsa5SnR5QKwhWJhASkE1JgQ3neOGIYZjWIEF ais6fa5eemwJ4TTOHuZmcEaIINFh+IQCHbUYfgNFPC0UGo8r20ltHlz67wll4laPtDEAW1s1ZDDeA OSM+x1iZPK4N8a/WbdgjVCkyrfE7ZVW3tTC5Rb2zhWrj2XU6QFnTTtQ2o5D90Q8huCKOySYus7w8R eRlzoNgP1/GDBj72YCkYtQ==; In-Reply-To: (message from Noah Peart on Sat, 13 Apr 2024 00:32:59 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283174 Archived-At: > From: Noah Peart > Date: Sat, 13 Apr 2024 00:32:59 -0700 > Cc: 70361@debbugs.gnu.org > > On a somewhat related note, I was wondering why the treesit modes in emacs > define their `treesit-font-lock-feature-list`s in the mode definitions. > > Wouldn't it be more user-friendly to `defvar` the feature list? AFAIR, we do that in the mode's settings because the translation of general categories into mode-specific settings is not easy, and because we want users to control that via the fontification level, not below that. What problems do you see with the current approach that would require more fine-grained user control? And why do you think a defvar is the proper way of providing such control?