From: Juri Linkov <juri@linkov.net>
To: martin rudalics <rudalics@gmx.at>
Cc: 69993@debbugs.gnu.org
Subject: bug#69993: Wrap window buffers while cycling
Date: Thu, 25 Apr 2024 20:40:51 +0300 [thread overview]
Message-ID: <86msph2vdo.fsf@mail.linkov.net> (raw)
In-Reply-To: <1e0dd4b7-5866-4645-a0a5-57850861dd71@gmx.at> (martin rudalics's message of "Thu, 25 Apr 2024 10:31:47 +0200")
>> There is one problem with this line:
>>
>> (add-to-list 'window-persistent-parameters '(tab-line-buffers . writable))
>>
>> This line is needed to be able to use 'window-swap-states'
>> because window-state-get/window-state-put should move the window
>> parameter 'tab-line-buffers' to the swapped window.
>
> Why does it have to be "writable"? 'window-swap-states' doesn't care
> about "writability".
Sorry, I don't know why I missed that cdr can be 't'
instead of 'writable'. Now fixed.
>> A third solution would be to support a lambda in
>> 'window-persistent-parameters' that will process
>> the parameter before saving. For example:
>>
>> (add-to-list 'window-persistent-parameters
>> '(tab-line-buffers . (lambda (p) (mapcar #'buffer-name p))))
>
> You would call that function in window.el here
>
> (when (and pers (or (not writable) (eq pers 'writable)))
> (setq list (cons (cons (car par) (cdr par)) list)))))
>
> iff WRITABLE is non-nil and you would not call it here in window.c
>
> /* If the window has a value for the parameter,
> save it. */
> p->window_parameters = Fcons (Fcons (XCAR (par), XCDR (par)),
> p->window_parameters);
This might be needed later for some other window parameters.
next prev parent reply other threads:[~2024-04-25 17:40 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 7:42 bug#69993: Wrap window buffers while cycling Juri Linkov
2024-03-25 9:41 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-25 17:16 ` Juri Linkov
2024-03-26 9:56 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-27 7:20 ` Juri Linkov
2024-03-27 8:48 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-28 7:54 ` Juri Linkov
2024-03-28 9:19 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-28 17:57 ` Juri Linkov
2024-03-29 8:45 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-29 16:35 ` Juri Linkov
2024-03-30 9:37 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-30 18:24 ` Juri Linkov
2024-03-31 8:32 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-02 6:37 ` Juri Linkov
2024-04-02 8:22 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-02 16:28 ` Juri Linkov
2024-04-03 8:24 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-03 17:45 ` Juri Linkov
2024-04-04 8:03 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-05 6:45 ` Juri Linkov
2024-04-05 9:08 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-05 16:32 ` Juri Linkov
2024-04-06 18:43 ` Juri Linkov
2024-04-07 8:23 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-09 6:35 ` Juri Linkov
2024-04-09 9:04 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-09 16:37 ` Juri Linkov
2024-04-10 8:46 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-10 17:45 ` Juri Linkov
2024-04-11 9:18 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-12 6:35 ` Juri Linkov
2024-04-12 8:37 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-12 16:23 ` Juri Linkov
2024-04-14 16:15 ` Juri Linkov
2024-04-16 6:38 ` Juri Linkov
2024-04-17 17:56 ` Juri Linkov
2024-04-24 16:39 ` Juri Linkov
2024-04-25 8:31 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-25 17:40 ` Juri Linkov [this message]
2024-04-02 16:34 ` Juri Linkov
2024-04-03 8:24 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-03 17:44 ` Juri Linkov
2024-04-04 6:22 ` Juri Linkov
2024-04-02 16:40 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86msph2vdo.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=69993@debbugs.gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).