From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dmitry@gutov.dev>, Yuan Fu <casouri@gmail.com>
Cc: 71562@debbugs.gnu.org, sb@dod.no
Subject: bug#71562: treesit-install-language-grammar fails to install typescript
Date: Sat, 15 Jun 2024 09:31:59 +0300 [thread overview]
Message-ID: <86msnmwwbk.fsf@gnu.org> (raw)
In-Reply-To: <47399af2-6982-4ce1-ad50-db426624edae@gutov.dev> (message from Dmitry Gutov on Sat, 15 Jun 2024 01:18:50 +0300)
> Date: Sat, 15 Jun 2024 01:18:50 +0300
> From: Dmitry Gutov <dmitry@gutov.dev>
>
> On 14/06/2024 21:18, Steinar Bang wrote:
> > Platform: emacs 29.3 from backports debian package (1:29.3+1-3~bpo12+1)
> > debian 12.5 "bookworm" (current stable) on amd64
> >
> > The 'M-x treesit-install-language-grammar RET typescript RET' fails
> > with:
> >
> > ⛔ Warning (treesit): Error encountered when installing language
> > grammar: (file-missing Setting current directory No such file or
> > directory /tmp/treesit-workdirN2u4XF/repo/src)
> >
> > I used defaults on all questions because I had no idea what else to put
> > there.
> >
> > I think the reason the command fails is that the repository
> > https://github.com/tree-sitter/tree-sitter-typescript
> > actually contains two tree-sitter parsers for typescript and tsx:
> > https://github.com/tree-sitter/tree-sitter-typescript/tree/master/typescript
> > https://github.com/tree-sitter/tree-sitter-typescript/tree/master/tsx
>
> FWIW, this is more or less intended, since we don't store the exact urls
> for the grammars (in the default settings), and just infer them
> according to the common scheme.
>
> But we could change that in some cases, and perhaps typescript is
> popular enough for us to do that.
We could look for directories names 'src' which have either parser.c
or parser.cc, and take it from there, instead of hard-coding the place
of the 'src' directory in the hierarchy.
I've added Yuan to the discussion.
next prev parent reply other threads:[~2024-06-15 6:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 18:18 bug#71562: treesit-install-language-grammar fails to install typescript Steinar Bang
2024-06-14 22:18 ` Dmitry Gutov
2024-06-15 6:31 ` Eli Zaretskii [this message]
2024-06-15 19:30 ` Dmitry Gutov
2024-06-16 5:16 ` Eli Zaretskii
2024-06-19 6:33 ` Yuan Fu
2024-06-19 18:51 ` Steinar Bang
2024-06-19 19:14 ` Eli Zaretskii
2024-06-19 19:51 ` Dmitry Gutov
2024-06-20 4:54 ` Eli Zaretskii
2024-06-20 10:28 ` Dmitry Gutov
2024-06-20 10:45 ` Eli Zaretskii
2024-06-20 11:18 ` Dmitry Gutov
2024-06-20 11:31 ` Eli Zaretskii
2024-06-20 15:03 ` Dmitry Gutov
2024-06-20 15:59 ` Eli Zaretskii
2024-06-20 16:08 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86msnmwwbk.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=71562@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=dmitry@gutov.dev \
--cc=sb@dod.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).