From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: James Thomas via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#71720: [PATCH] Do not prematurely truncate python eldoc string Date: Sun, 23 Jun 2024 02:42:04 +0530 Message-ID: <86msncvg0r.fsf@gmx.net> References: <86frt5xi3e.fsf@outlook.com> <86jzihgmet.fsf@gnu.org> <86ed8pgenb.fsf@gnu.org> Reply-To: James Thomas Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17086"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: kobarity , 71720@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 22 23:13:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sL832-0004JH-0i for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Jun 2024 23:13:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sL82n-0000tl-NC; Sat, 22 Jun 2024 17:13:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sL82h-0000tI-9A for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 17:13:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sL82g-0001gA-Ft for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 17:13:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sL82g-0004Uo-FH for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 17:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: James Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Jun 2024 21:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71720 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71720-submit@debbugs.gnu.org id=B71720.171909074217210 (code B ref 71720); Sat, 22 Jun 2024 21:13:02 +0000 Original-Received: (at 71720) by debbugs.gnu.org; 22 Jun 2024 21:12:22 +0000 Original-Received: from localhost ([127.0.0.1]:60460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sL821-0004TW-SH for submit@debbugs.gnu.org; Sat, 22 Jun 2024 17:12:22 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:37617) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sL81z-0004TB-Bs for 71720@debbugs.gnu.org; Sat, 22 Jun 2024 17:12:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1719090732; x=1719695532; i=jimjoe@gmx.net; bh=Hoyh7Yg8XB8YtN6Ot70s7COSVqyLFI+1SmxWSxoQ2Fw=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=sJPdIHVYo+fnx+fSZsXfonsQjXB4eHf2E6N2XHORnAKkiJS1/JNnycKWeOVcJkPA P2/mSyIs97hc1d22K0wUHTeaw+9xNC4aAgE4OVdwP8OjP3PlIxqLvqVjgUxh5SSTE o2fPXRCQ5pv7UFCjVZS5hvR+ZPwyI0s2OSbXumRfRkT88iD59QbUucYef8wjsG8r2 Lm63eyP5bPzdaNV9WFvRkkNMnJVTCN2XLh5i0kqrGK4+1cNN0SA/W7aF9f+VcgjCI 1iXTNqvxoxBNBiBW4SchKBTZZDSmwVbaoFVnt7Mm8ZCbCcsCZvWXC4pCeuUMlos7a vJBnT6W0wXFsZ8ptwQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from user-Inspiron-3493 ([117.242.203.20]) by mail.gmx.net (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MUGeB-1rtwG81pq7-00PpFp; Sat, 22 Jun 2024 23:12:12 +0200 In-Reply-To: <86ed8pgenb.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 22 Jun 2024 18:50:48 +0300") X-Provags-ID: V03:K1:JP0DAGsQML5le+9mVvTkQU8urbAvqTLGh78q8nUTn2di28kJGOg tccdP4196VTy+q+823y10wby8nxnLmAJFfJzSvReCwooyfzLAeKhUk0oVhH39Z2qLa7TMeh 96CBYuI5aQwn+OQQnHPMllvjXIdj0I5R+qewSoczFImED1ZcjLS18KxCLlRZyVPHsKVYHs3 mi/4gldafNNeB3cRNMADA== UI-OutboundReport: notjunk:1;M01:P0:c2bWmCH2sNc=;IMEG/q3BU8XTOZOJoPfB+dx7wIw 1srooe1qbaH7bBXkXhIiW3vMjss55DXIXzNvewPUtpHQUZGxDqMQvg4B1EJ89RBqH2BajoKkk J70jRQCv5uxgfMm4G2oA1F7eObgl98k3kEWcP6aBNq4PszKtc4A93y6+LNIgI0zkebkUI8LfS 5/qzuCP8oybAsdMGLaQY+nF7lXRj//vjdDM/IabGEXCBiN96pqEEZyBEbG20Id5/vfvUdy/Wc ufXncLBM35e6krOAhpODd/z13sBv5AmvsxGnvHuKep+NW9YGj3zd0RMFnQ655scu2D3UJG3Ti RmHqNio0FDlZYGqcjrgPUsanHn+KAkh8alt6txa1JX6PFoUQfvgyJzrIWlu6IijdBZ4dfbKCt ODEBYMh7Atvg8oL7jrBMXAeegZGeS+wVX0c9sTyF/V/SzkhN+0MsNvMuKOcvuYX0kIYtO5bac jJQeD5+eyszn444kuL6Gcl11441zRE3IQXKVZNEMuTJ51zN5d/s3q4z01pNr5SNGzKvnKTRF8 dXshTh/IkSpavWo5boj2jcNCtqvqqRDb4Q4MAsbXoEJUADe8lxBtrM6MdWMAAbeSejM8ZhBJD wN5Q/1I/1EiLBuzhdEE/hRIjord3bmTXcIjTYyL5ztQF3poaMFEgqHm7CwgxQk0Ank3LiVA58 +U7v57EirUnI/JkRT7qRGIrAg9ebpLj9R9RBclZzAfHUPKuzNclg8qNYohytMC3c9UGeRlWeQ O8IXLqPv+AQrl8H9rSZU4TANvWFs8PobwYOzQNrJx22dC/kHYlFZLhY/wKFmMV+9t7WHU6bA X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287738 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Eli Zaretskii wrote: >> Date: Sat, 22 Jun 2024 23:16:51 +0900 >> From: kobarity >> Cc: 71720@debbugs.gnu.org >> >> Eli Zaretskii wrote: >> > >> > kobarity, any comments? >> >> I agree with this fix. For those who want the same behavior as >> before, setting eldoc-echo-area-use-multiline-p to nil should be >> sufficient. It might be better to make this change known in etc/NEWS, >> though. > > Thanks. > > James, can you add a NEWS entry and resubmit? How about this? --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Do-not-prematurely-truncate-python-eldoc-string.patch Content-Description: [PATCH] Do not prematurely truncate python eldoc string Content-Transfer-Encoding: quoted-printable =46rom 905983647acc87c0e9c9b76fa7922d0288af20b9 Mon Sep 17 00:00:00 2001 From: James Thomas Date: Sat, 22 Jun 2024 17:57:00 +0530 Subject: [PATCH] Do not prematurely truncate python eldoc string 'eldoc-echo-area-use-multiline-p' is there for that. * lisp/progmodes/python.el (python-eldoc-setup-code): Make the change. =2D-- etc/NEWS | 5 +++++ lisp/progmodes/python.el | 2 -- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index 2349cc0cacb..f810b3d04a3 100644 =2D-- a/etc/NEWS +++ b/etc/NEWS @@ -1499,6 +1499,11 @@ interactive Python interpreter specified by 'python= -interpreter'. It sends the python block delimited by 'python-nav-beginning-of-block' and 'python-nav-end-of-block' to the inferior Python process. +*** 'eldoc' no longer truncates to a single line by default. +Previously, the entire docstring was not available to eldoc, which made +'eldoc-echo-area-use-multiline-p' ineffective. The old behaviour may be +kept by setting that. + ** Inferior Python mode --- diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el index bb2bf1731b4..a52e21f625e 100644 =2D-- a/lisp/progmodes/python.el +++ b/lisp/progmodes/python.el @@ -5607,8 +5607,6 @@ python-eldoc-setup-code doc =3D '{objtype} {name}{args}'.format( objtype=3Dobjtype, name=3Dname, args=3Dargs ) - else: - doc =3D doc.splitlines()[0] except: doc =3D '' return doc" =2D- 2.43.0 --=-=-= Content-Type: text/plain -- --=-=-=--