From: Eli Zaretskii <eliz@gnu.org>
To: "Augusto Stoffel" <arstoffel@gmail.com>,
"João Távora" <joaotavora@gmail.com>
Cc: 72343@debbugs.gnu.org
Subject: bug#72343: [PATCH] Fix eglot-server-programs for TeX modes
Date: Sun, 28 Jul 2024 21:20:59 +0300 [thread overview]
Message-ID: <86msm1z8c4.fsf@gnu.org> (raw)
In-Reply-To: <87sevtz8xg.fsf@gmail.com> (message from Augusto Stoffel on Sun, 28 Jul 2024 20:08:11 +0200)
> From: Augusto Stoffel <arstoffel@gmail.com>
> Date: Sun, 28 Jul 2024 20:08:11 +0200
>
> I noticed Eglot currently sends the languageId "tex" in all TeX-derived
> modes, which is not correct; it should be "latex", "bibtex", etc.
>
> See the attached patch for a fix.
João, any objections to installing this on the emacs-30 release
branch?
> >From 754127ad8bfa6ade7fe9a836df2a8bea75d711ea Mon Sep 17 00:00:00 2001
> From: Augusto Stoffel <arstoffel@gmail.com>
> Date: Sun, 28 Jul 2024 20:03:35 +0200
> Subject: [PATCH] Fix eglot-server-programs for TeX modes
>
> * lisp/progmodes/eglot.el (eglot-server-programs): Add a dedicated entry
> to each TeX format, since the languageId passed to the server is derived
> from it.
> ---
> lisp/progmodes/eglot.el | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
> index 5845aff39b7..ea60b5d9a72 100644
> --- a/lisp/progmodes/eglot.el
> +++ b/lisp/progmodes/eglot.el
> @@ -292,8 +292,11 @@ eglot-server-programs
> (scala-mode . ,(eglot-alternatives
> '("metals" "metals-emacs")))
> (racket-mode . ("racket" "-l" "racket-langserver"))
> - ((tex-mode context-mode texinfo-mode bibtex-mode)
> - . ,(eglot-alternatives '("digestif" "texlab")))
> + (plain-tex-mode "digestif")
> + (latex-mode . ,(eglot-alternatives '("digestif" "texlab")))
> + (context-mode "digestif")
> + (texinfo-mode "digestif")
> + (bibtex-mode . ,(eglot-alternatives '("digestif" "texlab")))
> (erlang-mode . ("erlang_ls" "--transport" "stdio"))
> ((yaml-ts-mode yaml-mode) . ("yaml-language-server" "--stdio"))
> (nix-mode . ,(eglot-alternatives '("nil" "rnix-lsp" "nixd")))
> --
> 2.45.2
>
next prev parent reply other threads:[~2024-07-28 18:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-28 18:08 bug#72343: [PATCH] Fix eglot-server-programs for TeX modes Augusto Stoffel
2024-07-28 18:20 ` Eli Zaretskii [this message]
2024-07-28 21:31 ` João Távora
2024-07-29 6:15 ` Augusto Stoffel
2024-07-29 11:26 ` Eli Zaretskii
2024-07-30 18:20 ` Augusto Stoffel
2024-07-30 20:29 ` João Távora
[not found] ` <CAHixrvYMZTMRSpixw2CAkdx_b+hdPZDkB7s+1X1sUX4E7jPWHw@mail.gmail.com>
[not found] ` <CALDnm50sjTEnSxJ3Rzna3pets2bjHnVF=6vix1gM_54+VoHNvQ@mail.gmail.com>
2024-08-02 15:13 ` Augusto Stoffel
2024-08-02 15:29 ` João Távora
2024-08-06 15:04 ` Augusto Stoffel
2024-08-06 15:34 ` João Távora
2024-08-06 15:45 ` Augusto Stoffel
2024-08-06 16:27 ` João Távora
2024-08-06 16:38 ` Augusto Stoffel
2024-08-06 18:08 ` João Távora
2024-08-06 18:48 ` Augusto Stoffel
2024-08-06 22:52 ` João Távora
2024-08-07 7:02 ` Augusto Stoffel
2024-08-07 8:47 ` João Távora
2024-08-07 9:17 ` Augusto Stoffel
2024-08-07 13:17 ` João Távora
2024-08-07 6:33 ` Augusto Stoffel
2024-08-07 13:23 ` João Távora
2024-08-12 16:37 ` Philip Kaludercic
2024-08-12 16:53 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86msm1z8c4.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=72343@debbugs.gnu.org \
--cc=arstoffel@gmail.com \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).