From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72517: 31.0.50; [PATCH] Close X connection upon deletion of last emacsclient frame Date: Thu, 08 Aug 2024 08:29:47 +0300 Message-ID: <86mslnmvjo.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30816"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72517@debbugs.gnu.org To: Thomas Fitzsimmons , Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 08 07:30:49 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sbvjd-0007ps-ET for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Aug 2024 07:30:49 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sbvjS-0005hN-5k; Thu, 08 Aug 2024 01:30:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbvjQ-0005go-Bn for bug-gnu-emacs@gnu.org; Thu, 08 Aug 2024 01:30:36 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sbvjQ-0004Pt-2w for bug-gnu-emacs@gnu.org; Thu, 08 Aug 2024 01:30:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=pFDE8F8K0wwnmJQ4CznBBMzuNdFom7++4KZ7gayrbfU=; b=rvtrS3r7KghuiEK1Y0DldHg4d8j9b9gcTa2G2vhH43zt7FzHq/FIjb2w8KttbHbxQFimkjorKq7oHprViZbLfTy3WNVj/FBT81itB84V3+uBm9jsXGY7CNPCcm1gxGAqk2AjCCuNIz1CGU/8X3wodakgRboCl5t3RygeokBp7xYFw/CTLwbSPXxyVAufjMNraSJfMLd04xn9hCG48xRxOneyJVELcvUupMMga7z/w/vgnebplNBCa9MeQevWxE+o/kOVmTZU3qFaOnPdMQfsUqV1S2uZcNl6GTWq4OG1Hb6ji9mKZCNvSwwLT+Bgzur1pFT71IJKXdKUgBSuhkSM+Q==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sbvjq-0007F5-4k for bug-gnu-emacs@gnu.org; Thu, 08 Aug 2024 01:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Aug 2024 05:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72517 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 72517-submit@debbugs.gnu.org id=B72517.172309502327466 (code B ref 72517); Thu, 08 Aug 2024 05:31:02 +0000 Original-Received: (at 72517) by debbugs.gnu.org; 8 Aug 2024 05:30:23 +0000 Original-Received: from localhost ([127.0.0.1]:35339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbvjC-00078v-VB for submit@debbugs.gnu.org; Thu, 08 Aug 2024 01:30:23 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57598) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbvjB-00078g-I3 for 72517@debbugs.gnu.org; Thu, 08 Aug 2024 01:30:22 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbvif-0004AV-LU; Thu, 08 Aug 2024 01:29:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=pFDE8F8K0wwnmJQ4CznBBMzuNdFom7++4KZ7gayrbfU=; b=SaCjEYDCzk3z Cy8cvwPUvI75MrepqNYrM7pEnOegf7x59/zpPzCRkoh5lub2Dpnu23lYXioQxAumO2JFi0Dpw5Svv nArzFLdqZNZbqQYCZKcPQFKKj3O0goWbpVdu2r38ceVtHtrMY4p8sVYrjkBtOpru41CTvMzHLfmcb PBTtDRPwpU92j0xw9VIPZ88uuPDEbTTWVTXJlou9i3ic3yul/fG73WINJrHxErmHhe4PRmYn9T/ZC MjBbg8xUhppDBRSl3MXNbw1z/pjojbBh3rzv1z0DtIYmdgWTjkRqXcqdAJYJJb4N79UmS6X5Us1sE 3q7yTFR1e1fXi6GfLNuaeg==; In-Reply-To: (message from Thomas Fitzsimmons on Wed, 07 Aug 2024 20:47:48 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289913 Archived-At: > From: Thomas Fitzsimmons > Date: Wed, 07 Aug 2024 20:47:48 -0400 > > The attached patch fixes an issue reported on the mailing list [1]. > After quitting a remote "emacsclient -c" frame using C-x 5 0, the SSH > session will hang on exit. It is waiting for the X11 display connection > to be closed, but Emacs never closes it. > > I have been using this patch for a few months without issue, with the > Lucid toolkit, running "emacsclient -c" over a remote X11 connection. > > I just retested it on master (423c86cbde7b1ed1d42c7e21fef6e8be872857b0) > with "./configure --with-x-toolkit=lucid" and it works for me. > > I would like others who use remote X11 emacsclient to try the patch, to > make sure it does not introduce crashes, error messages or warnings. If > it works for others, I can push the patch to master. Thanks, but "ssh -X" is not the only way of starting a remote client session, is it? How do we know closing the X connection is TRT in all the cases, and cannot do any harm in some use cases other than yours? I'm also surprised that such a fundamental problem is raised only now, when remote connections existed for decades. Are you saying this is a regression due to some recent change we installed? If not, how come this went undetected for so many years? Po Lu, any comments or suggestions?