From: Eli Zaretskii <eliz@gnu.org>
To: Thomas Fitzsimmons <fitzsim@fitzsim.org>, Po Lu <luangruo@yahoo.com>
Cc: 72517@debbugs.gnu.org
Subject: bug#72517: 31.0.50; [PATCH] Close X connection upon deletion of last emacsclient frame
Date: Thu, 08 Aug 2024 08:29:47 +0300 [thread overview]
Message-ID: <86mslnmvjo.fsf@gnu.org> (raw)
In-Reply-To: <m3le17j0wb.fsf@fitzsim.org> (message from Thomas Fitzsimmons on Wed, 07 Aug 2024 20:47:48 -0400)
> From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
> Date: Wed, 07 Aug 2024 20:47:48 -0400
>
> The attached patch fixes an issue reported on the mailing list [1].
> After quitting a remote "emacsclient -c" frame using C-x 5 0, the SSH
> session will hang on exit. It is waiting for the X11 display connection
> to be closed, but Emacs never closes it.
>
> I have been using this patch for a few months without issue, with the
> Lucid toolkit, running "emacsclient -c" over a remote X11 connection.
>
> I just retested it on master (423c86cbde7b1ed1d42c7e21fef6e8be872857b0)
> with "./configure --with-x-toolkit=lucid" and it works for me.
>
> I would like others who use remote X11 emacsclient to try the patch, to
> make sure it does not introduce crashes, error messages or warnings. If
> it works for others, I can push the patch to master.
Thanks, but "ssh -X" is not the only way of starting a remote client
session, is it? How do we know closing the X connection is TRT in all
the cases, and cannot do any harm in some use cases other than yours?
I'm also surprised that such a fundamental problem is raised only now,
when remote connections existed for decades. Are you saying this is a
regression due to some recent change we installed? If not, how come
this went undetected for so many years?
Po Lu, any comments or suggestions?
next prev parent reply other threads:[~2024-08-08 5:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 0:47 bug#72517: 31.0.50; [PATCH] Close X connection upon deletion of last emacsclient frame Thomas Fitzsimmons
2024-08-08 5:29 ` Eli Zaretskii [this message]
2024-08-08 7:23 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-08 8:56 ` Thomas Fitzsimmons
2024-08-08 9:22 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-08 10:09 ` Thomas Fitzsimmons
2024-08-08 10:24 ` Eli Zaretskii
2024-08-09 3:01 ` Thomas Fitzsimmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86mslnmvjo.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=72517@debbugs.gnu.org \
--cc=fitzsim@fitzsim.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).