From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72701: eglot crash when project-files-relative-names t Date: Sat, 07 Sep 2024 10:20:34 +0300 Message-ID: <86mskkylod.fsf@gnu.org> References: <7ddfb028-a182-486d-bb72-aeb26e0d1d4d@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1556"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72701@debbugs.gnu.org, shipmints@gmail.com To: joaotavora@gmail.com, Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 07 09:21:15 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1smpkx-0000EA-6I for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Sep 2024 09:21:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1smpkm-00081v-1d; Sat, 07 Sep 2024 03:21:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smpkj-00081X-VK for bug-gnu-emacs@gnu.org; Sat, 07 Sep 2024 03:21:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1smpkj-0005YW-Ja for bug-gnu-emacs@gnu.org; Sat, 07 Sep 2024 03:21:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=zjPQDQ4ZzulXUb/1r9FGU0yriDBKrpRX/604oAjq6Sc=; b=c1MiB6QYFJSG4g0VwSlac19etMJzziaxuSZI0VnQw2zvxzxI1oGQ7YivE52Wl4GY0eyWqcSDS6WJD7WfvofLBnsrGZ4wAMxglK9nBtr6jJwjud9gE2HOg/RFJ54LBXUqzi/HiKdHX2KoBJaEW+7/0s/Mlp8A8zAyb/67sOuBVno0ZKUopyOOypoqwGXudEfaHCDW0ULDMdnOdIVtqw5xhd6jeDT3jb00j9c0An5tidvGMI3AiBpDZxftKuIhbkjXoMl7BDLklZczZ0MXZZ/okcJYY/4NbQY0WxwwUfyfnxhoah7mIqDsFBqmNB9f3V8h11iCeGQQmtgBGRpZLqpWfQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1smpkk-0000YZ-0h for bug-gnu-emacs@gnu.org; Sat, 07 Sep 2024 03:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Sep 2024 07:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72701 X-GNU-PR-Package: emacs Original-Received: via spool by 72701-submit@debbugs.gnu.org id=B72701.17256936432104 (code B ref 72701); Sat, 07 Sep 2024 07:21:01 +0000 Original-Received: (at 72701) by debbugs.gnu.org; 7 Sep 2024 07:20:43 +0000 Original-Received: from localhost ([127.0.0.1]:54655 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smpkR-0000Xs-Bs for submit@debbugs.gnu.org; Sat, 07 Sep 2024 03:20:43 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smpkP-0000Xg-Vj for 72701@debbugs.gnu.org; Sat, 07 Sep 2024 03:20:42 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smpkK-0005V5-6x; Sat, 07 Sep 2024 03:20:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=zjPQDQ4ZzulXUb/1r9FGU0yriDBKrpRX/604oAjq6Sc=; b=dP0w3rlR9WNucAC0d8RW gvHQAMcIxIm0mrHafBkGOlayXAwzEr/Db6Vefn2aCaRDpWwNJ920gU1LysAt74gmTYiAJpxnv5AH+ JtxnnOmw5nDGyjO0kNL6+/gvFs/IyRarpI/6zWF4yrZfmAQt7hMfcQ1YwIv/FL0po57g3OgVJu0Nr qUVAINXREKfvHBuCaR7qyXy+KXeM04rZxD0wwJubi1iAuXpMnbwclSUNzQ5YVleX798t0pdwPhYmf tcZxh1ZfVSSBkREjRvacODhZ4zRivaNwOb6FLaGqQt+teUvpZgeIkIbyIY31ZQr5lfEVUM5IBiRgK oPG3GAHv1L79Zw==; In-Reply-To: <7ddfb028-a182-486d-bb72-aeb26e0d1d4d@gutov.dev> (message from Dmitry Gutov on Sat, 24 Aug 2024 02:51:16 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291351 Archived-At: Ping! Is this issue resolved and can be closed, or do we need to do anything else here? > Cc: 72701@debbugs.gnu.org > Date: Sat, 24 Aug 2024 02:51:16 +0300 > From: Dmitry Gutov > > On 23/08/2024 18:08, João Távora wrote: > > > Eglot could be one of those features if there's a performance advantage. > > But I doubt it, because server-supplied glob expressions may target the > > full file name (indeed likely the truename). > > If the glob can match the full name, and it's hard to separate it into > two matchers, I suppose there's not much that could be done. > > The binding is probably and an improvement for some off-in-the-future > scenario where somebody has Emacs 30 installed, but upgrades project.el > to some yet-unreleased version where the variable's default is flipped. > > > Maybe it's worth it nevertheless, > > dunno. Anyway while let-binding p-f-r-names to nil in Eglot could work, I > > don't think it's the right solution, especially since it probably triggers a > > compilation warning in older Emacsen which don't have this. > > A (defvar ...) at the top of the function's body would help. > > > >