From: Eli Zaretskii <eliz@gnu.org>
To: joaotavora@gmail.com, Dmitry Gutov <dmitry@gutov.dev>
Cc: 72701@debbugs.gnu.org, shipmints@gmail.com
Subject: bug#72701: eglot crash when project-files-relative-names t
Date: Sat, 07 Sep 2024 10:20:34 +0300 [thread overview]
Message-ID: <86mskkylod.fsf@gnu.org> (raw)
In-Reply-To: <7ddfb028-a182-486d-bb72-aeb26e0d1d4d@gutov.dev> (message from Dmitry Gutov on Sat, 24 Aug 2024 02:51:16 +0300)
Ping! Is this issue resolved and can be closed, or do we need to do
anything else here?
> Cc: 72701@debbugs.gnu.org
> Date: Sat, 24 Aug 2024 02:51:16 +0300
> From: Dmitry Gutov <dmitry@gutov.dev>
>
> On 23/08/2024 18:08, João Távora wrote:
>
> > Eglot could be one of those features if there's a performance advantage.
> > But I doubt it, because server-supplied glob expressions may target the
> > full file name (indeed likely the truename).
>
> If the glob can match the full name, and it's hard to separate it into
> two matchers, I suppose there's not much that could be done.
>
> The binding is probably and an improvement for some off-in-the-future
> scenario where somebody has Emacs 30 installed, but upgrades project.el
> to some yet-unreleased version where the variable's default is flipped.
>
> > Maybe it's worth it nevertheless,
> > dunno. Anyway while let-binding p-f-r-names to nil in Eglot could work, I
> > don't think it's the right solution, especially since it probably triggers a
> > compilation warning in older Emacsen which don't have this.
>
> A (defvar ...) at the top of the function's body would help.
>
>
>
>
next prev parent reply other threads:[~2024-09-07 7:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-18 15:43 bug#72701: eglot crash when project-files-relative-names t Ship Mints
2024-08-22 17:04 ` Ship Mints
2024-08-22 17:52 ` Eli Zaretskii
2024-08-22 17:53 ` Ship Mints
2024-08-22 20:38 ` João Távora
2024-08-23 15:07 ` Ship Mints
2024-08-23 22:49 ` João Távora
2024-08-22 23:22 ` Dmitry Gutov
2024-08-23 14:56 ` Ship Mints
2024-08-23 15:08 ` João Távora
2024-08-23 15:10 ` Ship Mints
2024-08-23 23:51 ` Dmitry Gutov
2024-09-07 7:20 ` Eli Zaretskii [this message]
2024-09-08 2:24 ` Dmitry Gutov
2024-09-08 10:56 ` João Távora
2024-09-08 20:51 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86mskkylod.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=72701@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=joaotavora@gmail.com \
--cc=shipmints@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).