From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#3468: drag and drop text Date: Sun, 29 Sep 2024 14:36:38 +0300 Message-ID: <86msjq4rp5.fsf@gnu.org> References: <20090604070321.177690@gmx.net> <8ba4e567-550e-4ac2-96f4-c6f7bacd78d0@imayhem.com> <86wmiv3p0r.fsf@gnu.org> <9bef55ae-e0aa-40d0-af77-7e7eac309b3a@imayhem.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4788"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 3468@debbugs.gnu.org To: Cecilio Pardo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 29 13:38:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1susFh-00015x-AR for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Sep 2024 13:38:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1susFI-00055Y-2e; Sun, 29 Sep 2024 07:37:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1susF6-00054z-8U for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2024 07:37:37 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1susF1-0001GA-1x for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2024 07:37:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=jk3Y1TfjTv7ZKnxXgwW9ufSPF9Wyh/d97mdVYaYp+AQ=; b=u1UUtFLdo/eDlBFAcHcCd/sFPqcZReR/ooQx/TnkID7iwb0lQEFGnnAIHgGD/tKwU5l5e8HO79dWvb4L8QERIQ/coieof3PqQjXi5hTHvw7DA7dGGQEUDlHAm/H5C0AB0M9djSAegX5EzArC85o0/oSwQuMEEeolfNcAb5RXe8cgHWvK0WwE1JF5/AM7M62wRRxEHFLdUpfjYOO/XbixupaOTQpjPPvY3FHm/JS4SxTDbcNn7vfBRSEgEYxDGiijstBLaOB8Ytf5GyX6M4+leoZdFSH3btBxzzIOrDHzgCjG6fExb8n5e9n9NT9ZaU9238xgVJMX3TeNMABwXVeMKQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1susFW-0007ZA-7Z for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2024 07:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Sep 2024 11:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 3468 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: help Original-Received: via spool by 3468-submit@debbugs.gnu.org id=B3468.172760984528984 (code B ref 3468); Sun, 29 Sep 2024 11:38:02 +0000 Original-Received: (at 3468) by debbugs.gnu.org; 29 Sep 2024 11:37:25 +0000 Original-Received: from localhost ([127.0.0.1]:40191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1susEu-0007XQ-NT for submit@debbugs.gnu.org; Sun, 29 Sep 2024 07:37:25 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1susEo-0007X3-Fj for 3468@debbugs.gnu.org; Sun, 29 Sep 2024 07:37:22 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1susED-0001Dd-Ot; Sun, 29 Sep 2024 07:36:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jk3Y1TfjTv7ZKnxXgwW9ufSPF9Wyh/d97mdVYaYp+AQ=; b=bCgOJg7gwASr FM5QjSokB28x1wFj9emxBZx8CKf0igoZ/tx6q6PXU4SMOrVFRENdH5tfED4/jpfpKAfQ7ZTgTIY2y b69qxCLVrdoC05fyu3Rb5pdAFdqijYI5+zD7pHaicOX2YUbRSFjYIR7foa/NkvyKS+JPkzB1SWJu0 DpcuQu7MajwgHtaGwA0amWoCrVYfJvdcqobOKKSkx9HtNKPEyt9QNOnUQWhgmHeS5pBL3oMxhi4FW lfNz47Ao/pdZR+T6rkk90jTpjt0Jgduq9BCI+87dXZMXfae42Jv7DZo8dGhPU9UsrX2A7T11rrHph gyZ2CGoyYbELev1KlOtHSQ==; In-Reply-To: <9bef55ae-e0aa-40d0-af77-7e7eac309b3a@imayhem.com> (message from Cecilio Pardo on Sun, 29 Sep 2024 13:17:26 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292631 Archived-At: > Date: Sun, 29 Sep 2024 13:17:26 +0200 > Cc: 3468@debbugs.gnu.org > From: Cecilio Pardo > > On 29/09/2024 9:19, Eli Zaretskii wrote: > > >> + if (files->fWide) > > > > What determines whether we get "wide" file names or ANSI file names? > > We want to get "wide" file names where possible, but I don't see where > > we request that? > > We can't request it, I suppose it depends on the OS version or the > program sending the drop. What did you see on Windows 11? Do we always receive "wide" file names? Did you try dragging file names whose characters are not supported by the current ANSI codepage, and if so, did it work? > > If this runs in a non-main thread, then we cannot do this: calling > > functions that manipulate Lisp data in non-main threads is a no-no. > > Can we instead delegate the actual processing to where > > WM_EMACS_DROPSTRING is processed? If not, why not? > > It runs indeed on the "shell thread". I'll move all the processing to > the message handler. Thanks. By "message handler" you mean w32_read_socket, yes? > Thanks a lot for your review, and sorry for all the style mistakes. No need to apologize, it takes time to learn the subtleties of our conventions.