From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73766: 30.0.91; (documentation 'pcase) can take several seconds Date: Sat, 12 Oct 2024 12:22:13 +0300 Message-ID: <86msj9y8u2.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37019"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73766@debbugs.gnu.org To: Yikai Zhao , Stefan Monnier , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 12 11:23:03 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1szYKz-0009O2-EI for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Oct 2024 11:23:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1szYKp-0007eo-Er; Sat, 12 Oct 2024 05:22:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szYKm-0007eK-QL for bug-gnu-emacs@gnu.org; Sat, 12 Oct 2024 05:22:49 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1szYKm-0007Dn-HM for bug-gnu-emacs@gnu.org; Sat, 12 Oct 2024 05:22:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=LtXx9cNyDb5xzRrbl76AXOwC9YnWY9fJvXVmHtTcaT0=; b=Xlc7F/1TaqT13NVxkjLyCvWRBoslWfIV2B1meRFJ8d6jQoJcDQVabuFAqm16XGvfVuUms/IznT8jPaKazZ3qVm33nXNkKE5epCKdtoj4yv3ZzfOHJeyQWJ0Ozkv80OIUI0KDuuxjS4LCCSQ1vlc4wAr650K6299SfmAMTzJsWMLpmKAjC+hK3X5A1QlhB/E/dl3nNz/nIkcDbgRrqjegiPu0jerakfcWMXVWJ17I4oE0zyDWZXGVfUVs9wKbpGV5pgIV4LsSfQ/Cm7CIc1CXaTI2TnH9clFTfJHv7CyXj5csTdMonqm6nLyx0y7HVGBvzMcxnD8ViYpAIl/9LvNYRA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1szYL0-00085Z-BG for bug-gnu-emacs@gnu.org; Sat, 12 Oct 2024 05:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Oct 2024 09:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73766 X-GNU-PR-Package: emacs Original-Received: via spool by 73766-submit@debbugs.gnu.org id=B73766.172872496031061 (code B ref 73766); Sat, 12 Oct 2024 09:23:02 +0000 Original-Received: (at 73766) by debbugs.gnu.org; 12 Oct 2024 09:22:40 +0000 Original-Received: from localhost ([127.0.0.1]:36311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szYKd-00084u-PJ for submit@debbugs.gnu.org; Sat, 12 Oct 2024 05:22:40 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szYKa-00084c-VW for 73766@debbugs.gnu.org; Sat, 12 Oct 2024 05:22:37 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szYKH-0007Cy-CB; Sat, 12 Oct 2024 05:22:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=LtXx9cNyDb5xzRrbl76AXOwC9YnWY9fJvXVmHtTcaT0=; b=OuYKHhbszq5KTu/XOq7X L+5fRDMb7btiG7iLcZj8LZz15vX3ez50NmUWqKdLYqH9Sp/PRwJkxphokwckgwZxX6em7sBQnoH06 Tow9TxG76AOprk4uj73jBB7SULZIdd4T4MVb+FhGqb1HqRb8QLnEZ1Urph9QKLIXbKX8he7ifZmn0 1oISrFB0gibBMql7CglimJhFJEUYVwU78RY1GRtMYf9b/vV0hjr6sbf9GpyZZOYvSL9kuT/dFOp6Q Oa0Mz3SShZNXotrU2ecJlIRgzFeyhg9nvylk1taHvFXrkjEaG+KHNXM3epofKJqMccLXJHBHRwAyo IEbzxAbfD377yA==; In-Reply-To: (message from Yikai Zhao on Sat, 12 Oct 2024 16:02:04 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293406 Archived-At: > From: Yikai Zhao > Date: Sat, 12 Oct 2024 16:02:04 +0800 > > When `lsp-mode` is loaded, `(documentation 'pcase)` can take several > seconds to complete. > > Apparently, it would iterate over all defined pcase macros (N), and for > each of those, `help-fns-short-filename` would iterate over all items in > `load-path` (M). Total time complexity is N*M. > > In my case, N is about ~400 (defined in lsp-protocols.el) and M is about > ~100 (I think it's a normal case?). > > This is especially problematic since the `documentation` method can be > invoked by eldoc, which affects the responsiveness during editing. > > -- > > Here's my profiler result: > > 2713 86% - timer-event-handler > 2713 86% - apply > 2707 86% - # F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_12> > 2707 86% - eldoc-print-current-symbol-info > 2707 86% - eldoc--invoke-strategy > 2707 86% - eldoc-documentation-default > 2707 86% - # F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_17> > 2707 86% - elisp-eldoc-funcall > 2707 86% - elisp-get-fnsym-args-string > 2707 86% - documentation > 2707 86% - pcase--make-docstring > 2606 82% - help-fns-short-filename > 2598 82% - file-relative-name > 335 10% file-remote-p > 27 0% string-prefix-p Adding Stefan and João, in case they have some comments or suggestions.