From: Eli Zaretskii <eliz@gnu.org>
To: Madhu <enometh@meer.net>
Cc: monnier@iro.umontreal.ca, 74208@debbugs.gnu.org
Subject: bug#74208: 31.0.50; minibuffer read-file-name-default mutates global value of default-directory incorrectly
Date: Sun, 10 Nov 2024 08:00:35 +0200 [thread overview]
Message-ID: <86msi7ljb0.fsf@gnu.org> (raw)
In-Reply-To: <20241110.062700.1848871414792572122.enometh@meer.net> (message from Madhu on Sun, 10 Nov 2024 06:27:00 +0530 (IST))
> Cc: 74208@debbugs.gnu.org
> Date: Sun, 10 Nov 2024 06:27:00 +0530 (IST)
> From: Madhu <enometh@meer.net>
>
> --- a/lisp/minibuffer.el
> +++ b/lisp/minibuffer.el
> @@ -3668,10 +3668,11 @@ read-file-name-default
> ;; changing `default-directory' in the current buffer,
> ;; we don't let-bind it.
> (let ((dir (file-name-as-directory
> - (expand-file-name dir))))
> + (expand-file-name dir)))
> + (default-directory (if (file-name-absolute-p dir)
> + dir default-directory)))
You probably meant to use let*, right?
But anyway, I don't understand the logic: expand-file-name always
returns an absolute file name, so the test will always succeed. What
did I miss?
next prev parent reply other threads:[~2024-11-10 6:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 2:09 bug#74208: 31.0.50; minibuffer read-file-name-default mutates global value of default-directory incorrectly Madhu
2024-11-09 11:11 ` Eli Zaretskii
2024-11-09 16:11 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-10 0:57 ` Madhu
2024-11-10 6:00 ` Eli Zaretskii [this message]
2024-11-10 7:00 ` Madhu
2024-11-10 10:00 ` Eli Zaretskii
2024-11-10 10:41 ` Madhu
2024-11-10 10:45 ` Eli Zaretskii
2024-11-10 11:17 ` Madhu
2024-11-10 11:26 ` Eli Zaretskii
2024-11-10 16:54 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-11 2:17 ` Madhu
2024-11-11 3:40 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-23 12:25 ` Eli Zaretskii
2024-11-23 14:56 ` Madhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86msi7ljb0.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=74208@debbugs.gnu.org \
--cc=enometh@meer.net \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).