unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "john muhl" <jm@pub.pink>
Cc: 75018@debbugs.gnu.org
Subject: bug#75018: 30.0.93; Dired icon missing in tool-bar
Date: Sun, 22 Dec 2024 18:40:45 +0200	[thread overview]
Message-ID: <86msgn6582.fsf@gnu.org> (raw)
In-Reply-To: <6bfb0822-f2e9-48d5-bcf3-0012fc432782@app.fastmail.com> (jm@pub.pink)

> Date: Sun, 22 Dec 2024 09:32:23 -0600
> From: "john muhl" <jm@pub.pink>
> Cc: 75018@debbugs.gnu.org
> 
> On Sun, Dec 22, 2024, at 12:43 AM, Eli Zaretskii wrote:
> >> From: john muhl <jm@pub.pink>
> >> Date: Sat, 21 Dec 2024 18:19:57 -0600
> >> 
> >> The usual Dired icon is missing and instead shows up as a couple
> >> of tiny triangles in the normal state and as a very generic file
> >> icon on hover. Happens on emacs-30 and master and X11 and PGTK
> >> builds. Lucid and Motif builds are unaffected.
> >
> > Where do the tool-bar icons come from in that build?  They are not
> > from the Emacs's etc/images/ directory, AFAICT.
> 
> They are the stock GTK icons. On this system they are located in
> /usr/share/icons/. The option x-gtk-stock-map is responsible for
> the mapping between Emacs' etc/images/* and the system's
> icons. The attached patch fixes it here.

Can you explain the rationale for the patch and how it solves the
problem?

> > Can you post the Dired icon file from where your build takes them?
> 
> Unfortunately I can't find those particular icons among the ~7000
> icons in the /usr/share/icons/ directory but they're probably in
> there somewhere.

If you run Emacs under GDB with a breakpoint in lookup_image, you
should see all the tool-bar icons being loaded during startup.  You
can use the following GDB commands for the breakpoint, to see when the
icon you are interested in gets loaded:

  pp spec

This should show you the full absolute file name of the icon file
Emacs is loading.

The command "pp" is defined in src/.gdbinit, so if you don't start GDB
from that directory, you will need to say

  (gdb) source /path/to/emacs/src/.gdbinit

before running Emacs, to be able to use this useful command.

> > Also, is this problem new in the last pretest, or did previous
> > pretests behave the same?
> 
> I tried 30.0.90 and 29.4 and they too are using the incorrect
> icons. I suspect upgrading to Fedora 41 is what causes the
> issue.

Yes, that's usually the first suspect in such cases.

Thanks.





  reply	other threads:[~2024-12-22 16:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-22  0:19 bug#75018: 30.0.93; Dired icon missing in tool-bar john muhl
2024-12-22  6:43 ` Eli Zaretskii
2024-12-22 15:32   ` john muhl
2024-12-22 16:40     ` Eli Zaretskii [this message]
2024-12-22 18:15       ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-22 18:45         ` Eli Zaretskii
2024-12-22 21:34           ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-22 19:45       ` john muhl
2024-12-22 19:52         ` john muhl
2024-12-22 23:57           ` john muhl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86msgn6582.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=75018@debbugs.gnu.org \
    --cc=jm@pub.pink \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).