From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Oleksandr Gavenko Newsgroups: gmane.emacs.bugs Subject: bug#28434: 25.2; Final "\ No newline at end of file" breaks Emacs patch handling. Date: Tue, 12 Sep 2017 21:01:14 +0300 Message-ID: <86lglj6bkl.fsf@gavenkoa.example.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1505239338 29424 195.159.176.226 (12 Sep 2017 18:02:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 12 Sep 2017 18:02:18 +0000 (UTC) To: 28434@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 12 20:02:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drpVc-0006z3-NM for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Sep 2017 20:02:04 +0200 Original-Received: from localhost ([::1]:37888 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drpVk-0005AE-6D for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Sep 2017 14:02:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37828) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drpVe-00059Z-EF for bug-gnu-emacs@gnu.org; Tue, 12 Sep 2017 14:02:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drpVb-0000fx-Cj for bug-gnu-emacs@gnu.org; Tue, 12 Sep 2017 14:02:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55828) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1drpVb-0000fr-8c for bug-gnu-emacs@gnu.org; Tue, 12 Sep 2017 14:02:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1drpVZ-00077t-Vw for bug-gnu-emacs@gnu.org; Tue, 12 Sep 2017 14:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Oleksandr Gavenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Sep 2017 18:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 28434 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.150523929527358 (code B ref -1); Tue, 12 Sep 2017 18:02:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 12 Sep 2017 18:01:35 +0000 Original-Received: from localhost ([127.0.0.1]:36276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drpV8-00077C-Lj for submit@debbugs.gnu.org; Tue, 12 Sep 2017 14:01:35 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drpV7-000770-Eo for submit@debbugs.gnu.org; Tue, 12 Sep 2017 14:01:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drpV1-0000PU-4s for submit@debbugs.gnu.org; Tue, 12 Sep 2017 14:01:28 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:52301) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1drpV1-0000PK-1Z for submit@debbugs.gnu.org; Tue, 12 Sep 2017 14:01:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37542) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drpUz-0004rP-Mk for bug-gnu-emacs@gnu.org; Tue, 12 Sep 2017 14:01:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drpUw-0000Nc-Lw for bug-gnu-emacs@gnu.org; Tue, 12 Sep 2017 14:01:25 -0400 Original-Received: from mail-lf0-x22a.google.com ([2a00:1450:4010:c07::22a]:37253) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1drpUw-0000Mp-Dv for bug-gnu-emacs@gnu.org; Tue, 12 Sep 2017 14:01:22 -0400 Original-Received: by mail-lf0-x22a.google.com with SMTP id 80so28408061lfy.4 for ; Tue, 12 Sep 2017 11:01:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=8ocB0fGTSfxEhWmJxgQu9tc3UciccQEYvW4eYbKrZqs=; b=nfPn8X3oK1m5PAVjkpVrMXKWLbj/ldHE7a+SBGZPgCeKaGd0Y4+DPeRkQVjifOIDk3 NDwSkw/FG+gMgfeUUnQkgs9OlGZV1YOCwoa/nmeR2aF9PWDqimvP3naG+cCQud220ArI JpkgpDFyK9N016V+F3PEdv7Gjr4H2ACurtEqfAHj/CUJTrvc3mt/n/o3L5LISW8TPhD8 on8BBKlP22o+IYDssQEKkCASbW8hIXkdkG/L/pEhhd7SRUBa2+Xr0VyPXGmdYmCXE4+H 8eLcJDfnCeqOMjc0DPJ928IsHaoxn9S5LAoOqpSwbcM/S0xbrx7tzytQD6QRPAVtGbWp DARg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=8ocB0fGTSfxEhWmJxgQu9tc3UciccQEYvW4eYbKrZqs=; b=cr/vuByz4qQvmrdzEc+E8X0SR6xHNS5ITIuKJHcbrV41zn6oVM5zqmFlUhIBo2KrkQ SriZlkRcpkoUNLoQMWqIidzdzkY55z9I09+BhxEN/GtYVOAOnYIneSJNK7222YxAoSaL bGsZo1dp20MOTyzT5/kNMhBZozJfem9kKy4L59ubzTfxc9r2kH4XB7Q+oT7hOYmUhp/r t86gJsBgMJiek6r6mFIEmbx1wvVDBPaEzXX5KfTL+sLr7gnXUpVvhOM2V6bw7jmYIiNd kwLbmzCYUpy/5hVOXdIiOttmeYhF4eOJqfzZIt7/DjLCTOyTXaSb3yzhSapsNYbcSgqP tvPw== X-Gm-Message-State: AHPjjUhjrLgQWiNT0ts+ZgfDWmAadD3Kx1CysYn/nRFKSDelz3eazKtR 3Brh9J4ROr5DtdkU X-Google-Smtp-Source: AOwi7QCDWvraI6hOPEHUB99HD9AxcLUEQvvdXvvH7djmpFcaxR7sRBCNxbx0Oxt73+RydxPLLnhMJA== X-Received: by 10.25.142.9 with SMTP id q9mr4751335lfd.89.1505239279367; Tue, 12 Sep 2017 11:01:19 -0700 (PDT) Original-Received: from DELLXPS ([46.118.15.174]) by smtp.gmail.com with ESMTPSA id 67sm2201048lfq.15.2017.09.12.11.01.15 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Sep 2017 11:01:16 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136843 Archived-At: In GNU Emacs 25.2.1 (i686-w64-mingw32) of 2017-04-24 built on LAPHROAIG It happens with a lot of tools (diff/hg/git). If file doesn't end on new li= ne diff file has: \ No newline at end of file C-c C-c (diff-goto-source) on that hunk says: Hunk text not found C-c C-a (diff-apply-hunk) says: diff-apply-hunk: Can=E2=80=99t find the text to patch It's very annoying as I have no control over file content and sometime can't add final new line. Emacs commands in diff mode should tolerate ``\`` message about missing fin= al new line. ediff-diff-ok-lines-regexp is: "^\\([0-9,]+[acd][0-9,]+?$\\|[<>] \\|---\\|.*Warning *:\\|.*No +newline\\= |.*missing +newline\\|^?$\\)" and match that line. I live with that problem from Emacs 22.x or so. Surprised why no one fixed = it yet. --=20 http://defun.work/