From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Newsgroups: gmane.emacs.bugs Subject: bug#51037: [PATCH] Make `print-level` & `print-length` customizable in ERT batch tests Date: Fri, 08 Oct 2021 08:24:42 -0700 Message-ID: <86lf33mtdx.fsf@runbox.com> References: <86tuhvmtpl.fsf@runbox.com> <877deqec10.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2182"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.4.15; emacs 28.0.50 Cc: 51037@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 08 17:25:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYrkG-0000Ju-P9 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 Oct 2021 17:25:13 +0200 Original-Received: from localhost ([::1]:59360 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYrkF-0007Bz-0i for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 Oct 2021 11:25:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39990) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYrk6-0007Br-T6 for bug-gnu-emacs@gnu.org; Fri, 08 Oct 2021 11:25:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40197) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mYrk6-000555-LW for bug-gnu-emacs@gnu.org; Fri, 08 Oct 2021 11:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mYrk6-0000yG-BP for bug-gnu-emacs@gnu.org; Fri, 08 Oct 2021 11:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Oct 2021 15:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51037 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51037-submit@debbugs.gnu.org id=B51037.16337066943713 (code B ref 51037); Fri, 08 Oct 2021 15:25:02 +0000 Original-Received: (at 51037) by debbugs.gnu.org; 8 Oct 2021 15:24:54 +0000 Original-Received: from localhost ([127.0.0.1]:51743 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYrjy-0000xp-6P for submit@debbugs.gnu.org; Fri, 08 Oct 2021 11:24:54 -0400 Original-Received: from aibo.runbox.com ([91.220.196.211]:51298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYrjv-0000xf-Cn for 51037@debbugs.gnu.org; Fri, 08 Oct 2021 11:24:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector2; h=Content-Type:MIME-Version:Message-ID:Date:In-reply-to:Subject :Cc:To:From:References; bh=z6Bc7GxG3aCAypa5she9bWROLxyCUYJs/KbR6W+udAA=; b=c3 B+samIS5jstN3LZZfXrsbqzg05LFKEGG1gkV5+4S7t+1jtSSePygVwnvTa2S1RtL8UDonL5XSE4vQ MwZb9KlaXtYy3VL0c5c38cQx9m4LxjXaCBeV8vtQWLMe8yTrmNdE+rEXzOt5vVFd2BidoPHjwk4Nw I3JTc59zWV7seCpwjFvqjBEWYoics3PzfQ31O6i7D0LzPkRZABhn6ueWbVxIikzQJimAsnbOfUXdY b4A9bkC8srnoDOZeF1CiyguW7jnoOfs22tmJ11grQusHawPIdajt5onycaofL8isbO1cGoUYcSW+r SpQLeV4TQlSmOQSEh3i+okRIjvNuDFEg==; Original-Received: from [10.9.9.72] (helo=submission01.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1mYrjt-0006Zc-0V; Fri, 08 Oct 2021 17:24:49 +0200 Original-Received: by submission01.runbox with esmtpsa [Authenticated ID (942723)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1mYrjr-0002uc-Pi; Fri, 08 Oct 2021 17:24:48 +0200 In-reply-to: <877deqec10.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216724 Archived-At: Lars Ingebrigtsen writes: > Michael writes: > >> When running ERT tests in batch mode, the conservative values >> chosen for `print-level` and `print-length` sometimes make it >> difficult to see what exactly is wrong. This patch introduces >> two new variables (`ert-batch-print-level` & >> `ert-batch-print-length`) that one can use to customize them; >> e.g. >> >> emacs -batch -l ert -l my-tests.el \ >> --eval "(let ((ert-batch-print-level 10) \ >> (ert-batch-print-length 120)) \ >> (ert-run-tests-batch-and-exit))" > > Sounds like a good idea. > >> +MESSAGE-FN should normally be nil; it is used for automated >> +self-tests and specify how to display messages." > > I don't understand this bit, though. If you want to test how > this > function outputs messages, you can just `cl-letf' like this: > > (cl-letf (((symbol-function 'message) ... Good point. I simply carried the strategy over from that used to unit test `ert-run-tests-interactively`. TBH I was unaware of `cl-letf`, and there *is* this comment above `ert-run-tests-interactively`: ;; Should OUTPUT-BUFFER-NAME and MESSAGE-FN really be arguments here? ;; They are needed only for our automated self-tests at the moment. ;; Or should there be some other mechanism? Perhaps I should change *both* to just use `cl-letf`? -- Michael