From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#51337: Subject: 27.2; mouse-buffer-menu-mode-groups Date: Mon, 08 Nov 2021 21:24:21 +0200 Organization: LINKOV.NET Message-ID: <86lf1ywivu.fsf@mail.linkov.net> References: <87sfwrd7ty.fsf@mail.linkov.net> <87wnm246kn.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2296"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 51337@debbugs.gnu.org, Peter Scott To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 08 20:26:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mkAHZ-0000T0-9c for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Nov 2021 20:26:17 +0100 Original-Received: from localhost ([::1]:50946 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mkAHY-00084W-16 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Nov 2021 14:26:16 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33538) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkAHP-000834-TP for bug-gnu-emacs@gnu.org; Mon, 08 Nov 2021 14:26:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47976) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mkAHK-0008TK-JT for bug-gnu-emacs@gnu.org; Mon, 08 Nov 2021 14:26:07 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mkAHK-0003O7-Bj for bug-gnu-emacs@gnu.org; Mon, 08 Nov 2021 14:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Nov 2021 19:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51337 X-GNU-PR-Package: emacs Original-Received: via spool by 51337-submit@debbugs.gnu.org id=B51337.163639951012949 (code B ref 51337); Mon, 08 Nov 2021 19:26:02 +0000 Original-Received: (at 51337) by debbugs.gnu.org; 8 Nov 2021 19:25:10 +0000 Original-Received: from localhost ([127.0.0.1]:59520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkAGT-0003Mm-Mf for submit@debbugs.gnu.org; Mon, 08 Nov 2021 14:25:09 -0500 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:54323) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkAGQ-0003M4-96; Mon, 08 Nov 2021 14:25:08 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 6F1ACE0007; Mon, 8 Nov 2021 19:24:57 +0000 (UTC) In-Reply-To: <87wnm246kn.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 24 Oct 2021 20:32:24 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219378 Archived-At: close 51337 28.0.60 quit >> Oh, it's unfortunate that "log\\|diff..." also matches "verilog". >> This regexp should be tightened to match only VC buffers, but >> not buffers from other modes. Maybe something like >> >> ("vc.*log\\|diff\\|vc\\|cvs\\|Git\\|Annotate" . "Version Control") > > Makes sense to me -- there's also a bunch of other buffers that have > names ending with "log", so it's not just about verilog buffers. Some examples of mode names that belong to "Version Control": "Log-Edit/git" (e.g. in a buffer named "*vc-log*") "Git-Log-View" (e.g. "*vc-change-log*", "*vc-search-log*") "Change Log" (e.g. "ChangeLog") "Diff" (e.g. "*vc-diff*") "VC dir" (e.g. "*vc-dir*") "Annotate" (e.g. "*Annotate file*") Grepping reveals more mode names belonging to "Version Control": "Log-Edit", "Log-View", "Bzr-Log-View", "Hg-Log-View", "Log-Edit/hg", "Mtn-Log-View", "SVN-Log-View" Whereas here is a list of mode names that should be excluded from "Version Control" and thus should not match: "Verilog", "Prolog", "Prolog[Mercury]", "Inferior Prolog", "Rlogin", "recentf-dialog" So I pushed this fix to emacs-28: diff --git a/lisp/mouse.el b/lisp/mouse.el index d6912892ef..aa73c80d61 100644 --- a/lisp/mouse.el +++ b/lisp/mouse.el @@ -2477,7 +2481,7 @@ mouse-buffer-menu-mode-groups ("Text" . "Text") ("Outline" . "Text") ("\\(HT\\|SG\\|X\\|XHT\\)ML" . "SGML") - ("log\\|diff\\|vc\\|cvs\\|Git\\|Annotate" . "Version Control") + ("\\blog\\b\\|diff\\|\\bvc\\b\\|cvs\\|Git\\|Annotate" . "Version Control") ("Threads\\|Memory\\|Disassembly\\|Breakpoints\\|Frames\\|Locals\\|Registers\\|Inferior I/O\\|Debugger" . "GDB") ("Lisp" . "Lisp"))) --