From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#51883: 29.0.50; Command to get accidentally deleted frames back Date: Sat, 22 Jan 2022 20:08:12 +0200 Organization: LINKOV.NET Message-ID: <86lez73auf.fsf@mail.linkov.net> References: <87czn1gfb1.fsf@web.de> <838rxo0zk7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7112"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: michael_heerdegen@web.de, gregory@heytings.org, monnier@iro.umontreal.ca To: 51883@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 22 19:21:05 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nBL0b-0001km-QN for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Jan 2022 19:21:05 +0100 Original-Received: from localhost ([::1]:44990 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nBL0a-0003XT-RG for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Jan 2022 13:21:04 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60942) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nBKyd-00020z-3S for bug-gnu-emacs@gnu.org; Sat, 22 Jan 2022 13:19:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44950) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nBKyc-0006fX-PU for bug-gnu-emacs@gnu.org; Sat, 22 Jan 2022 13:19:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nBKyc-0002SM-MI for bug-gnu-emacs@gnu.org; Sat, 22 Jan 2022 13:19:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Jan 2022 18:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51883 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" X-Debbugs-Original-Cc: michael_heerdegen@web.de, Eli Zaretskii , Gregory Heytings , Stefan Monnier , 51883@debbugs.gnu.org Original-Received: via spool by 51883-submit@debbugs.gnu.org id=B51883.16428755049361 (code B ref 51883); Sat, 22 Jan 2022 18:19:02 +0000 Original-Received: (at 51883) by debbugs.gnu.org; 22 Jan 2022 18:18:24 +0000 Original-Received: from localhost ([127.0.0.1]:37847 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nBKxz-0002Qp-St for submit@debbugs.gnu.org; Sat, 22 Jan 2022 13:18:24 -0500 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:36369) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nBKxy-0002QU-E5 for 51883@debbugs.gnu.org; Sat, 22 Jan 2022 13:18:22 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 0A0021C0003; Sat, 22 Jan 2022 18:18:13 +0000 (UTC) In-Reply-To: (Stefan Monnier via's message of "Fri, 21 Jan 2022 12:52:35 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224853 Archived-At: > But as for loading the package, the problem is more general in the sense > that maybe we should refrain from loading the package just because > a frame is deleted. > > So maybe we should change the code so the hook's function doesn't > require loading `frameset.el`. AFAICT fundamentally, the only function > from `frameset.el` that it needs is `frameset-filter-params`, so maybe > we should move some of that code to `frame.el`. > > To make up for it, maybe we can move some of the `undelete-frame` code > to `frameset.el` since it can't be used without `frameset.el` anyway? > >> . saving configurations of 16 deleted frames _by_default_ means we >> again impose on all users something that only some of them will use > > IIUC framesets are designed to be serializable so they shouldn't hold on > to external data like buffers and windows, so such 16 elements should > cost very little in terms of heap use. OTOH, since framesets are designed to be serializable, isn't it overkill to use framesets in the same session? For example, `clone-frame` doesn't use framesets, and the effect of `clone-frame` should be the same as what `undelete-frame` does. The difference between them is that with `clone-frame` the original frame is not deleted.