From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#51883: 29.0.50; Command to get accidentally deleted frames back Date: Sun, 30 Jan 2022 19:17:30 +0200 Organization: LINKOV.NET Message-ID: <86leyxjg7m.fsf@mail.linkov.net> References: <87czn1gfb1.fsf@web.de> <838rxo0zk7.fsf@gnu.org> <86czk9kxm8.fsf@mail.linkov.net> <83ilu19n31.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39625"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: michael_heerdegen@web.de, gregory@heytings.org, monnier@iro.umontreal.ca, 51883@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 30 18:20:50 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nEDsf-000ADe-SG for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Jan 2022 18:20:49 +0100 Original-Received: from localhost ([::1]:44862 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nEDse-0002lE-Aj for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Jan 2022 12:20:48 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53466) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEDrv-0002kl-3E for bug-gnu-emacs@gnu.org; Sun, 30 Jan 2022 12:20:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44649) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nEDru-0001Nx-OP for bug-gnu-emacs@gnu.org; Sun, 30 Jan 2022 12:20:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nEDru-0000LO-KI for bug-gnu-emacs@gnu.org; Sun, 30 Jan 2022 12:20:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Jan 2022 17:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51883 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51883-submit@debbugs.gnu.org id=B51883.16435631511255 (code B ref 51883); Sun, 30 Jan 2022 17:20:02 +0000 Original-Received: (at 51883) by debbugs.gnu.org; 30 Jan 2022 17:19:11 +0000 Original-Received: from localhost ([127.0.0.1]:37552 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEDr5-0000KA-Jy for submit@debbugs.gnu.org; Sun, 30 Jan 2022 12:19:11 -0500 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:35009) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEDqz-0000JX-VW for 51883@debbugs.gnu.org; Sun, 30 Jan 2022 12:19:10 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 6772460008; Sun, 30 Jan 2022 17:18:56 +0000 (UTC) In-Reply-To: <83ilu19n31.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 30 Jan 2022 18:59:14 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:225620 Archived-At: >> So all concerns raised by Eli are addressed now >> that make possible to enable it by default >> as was discussed on emacs-devel: > > Once again, please do NOT enable this by default, I didn't agree to > that. This feature should remain disabled by default for some time, > until we have enough information to discuss whether it should be > turned on by default. As discussed and agreed during its development. But after the recent discussion it was agreed to enable it by default after fixing raised concerns. Everything is fixed now. Should we restart the same discussion again? >> @item C-x 5 u >> @kindex C-x 5 u >> @findex undelete-frame >> -@findex undelete-frame-mode >> -When @code{undelete-frame-mode} is enabled, undelete one of the 16 >> -most recently deleted frames. Without a prefix argument, undelete the >> -most recently deleted frame. With a numerical prefix argument between >> -1 and 16, where 1 is the most recently deleted frame, undelete the >> -corresponding deleted frame. >> +@findex undelete-frame-max >> +Undelete one of the recently deleted frames. The user option > > "One of the recently deleted frames" sounds like Emacs arbitrarily > decides which one. Which is not what you wanted to say, surely. This was copied from old text: "undelete one of the 16 most recently deleted frames". >> +(defcustom undelete-frame-max 1 >> + "Maximum number of deleted frames before oldest are thrown away." > > This doesn't say how to disable the feature. This feature can be disabled by customizing it to 0. >> (bindings--define-key menu [undelete-last-deleted-frame] >> '(menu-item "Undelete Frame" undelete-frame >> - :enable (and undelete-frame-mode >> - (car undelete-frame--deleted-frames)) >> + :visible (car undelete-frame--deleted-frames) > > I think Gregory didn't like the disappearing item, and preferred it to > be visible at all times, even if disabled. The invisible item makes the already overly long menu shorter, especially for users who don't use frames.