From: Juri Linkov <juri@linkov.net>
To: martin rudalics <rudalics@gmx.at>
Cc: 53662@debbugs.gnu.org, Aaron Jensen <aaronjensen@gmail.com>
Subject: bug#53662: 29.0.50; Cannot use tab-new from side window
Date: Tue, 01 Feb 2022 21:31:56 +0200 [thread overview]
Message-ID: <86leyuo3rn.fsf@mail.linkov.net> (raw)
In-Reply-To: <3706eced-5023-767a-7dff-85423039e06d@gmx.at> (martin rudalics's message of "Tue, 1 Feb 2022 09:09:54 +0100")
[-- Attachment #1: Type: text/plain, Size: 1310 bytes --]
>> Martin, could you suggest how to ignore window-sideness
>> while splitting the side window? 'tab-bar-new-tab-to'
>> currently uses such trick to create a new window:
>>
>> (let ((ignore-window-parameters t))
>> (delete-other-windows))
>
> Usually, you can't make a side window the only window on its frame - the
> main window has to stay. If you ignore window parameters, you have to
> clean the state of windows yourself afterwards - for example, by giving
> the sole remaining window a 'window-side' parameter of nil. If you do
> not do that, the windows state of the frame is broken already before you
> try splitting the window below.
>
>> (unless (eq tab-bar-new-tab-choice 'window)
>> ;; Create a new window to get rid of old window parameters
>> ;; (e.g. prev/next buffers) of old window.
>> (split-window) (delete-window))
>>
>> but this fails in side windows.
>
> This is a hack and would fail in the case at hand since 'split-window'
> would set the 'window-side' parameter for the new window. I'd rather
> set all parameters of the selected window to nil instead.
Thanks, I confirm this fixes the problem with this patch.
Also ‘split-window’ and ‘delete-window’ were moved
inside ‘(ignore-window-parameters t)’ for more safety:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: tab-new-window-parameters.patch --]
[-- Type: text/x-diff, Size: 1218 bytes --]
diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el
index 06ad8f60af..43a56c806b 100644
--- a/lisp/tab-bar.el
+++ b/lisp/tab-bar.el
@@ -1361,12 +1361,17 @@ tab-bar-new-tab-to
;; Handle the case when it's called in the active minibuffer.
(when (minibuffer-selected-window)
(select-window (minibuffer-selected-window)))
+ ;; Remove all window parameters to prevent the case
+ ;; when e.g. `window-side' gets in the way.
+ (dolist (parameter (window-parameters))
+ (set-window-parameter nil (car parameter) nil))
(let ((ignore-window-parameters t))
- (delete-other-windows))
- (unless (eq tab-bar-new-tab-choice 'window)
- ;; Create a new window to get rid of old window parameters
- ;; (e.g. prev/next buffers) of old window.
- (split-window) (delete-window))
+ (delete-other-windows)
+ (unless (eq tab-bar-new-tab-choice 'window)
+ ;; Create a new window to get rid of old window parameters
+ ;; (e.g. prev/next buffers) of old window.
+ (split-window) (delete-window)))
+
(let ((buffer
(if (functionp tab-bar-new-tab-choice)
(funcall tab-bar-new-tab-choice)
next prev parent reply other threads:[~2022-02-01 19:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 15:25 bug#53662: 29.0.50; Cannot use tab-new from side window Aaron Jensen
2022-01-31 18:15 ` Juri Linkov
2022-02-01 8:09 ` martin rudalics
2022-02-01 19:31 ` Juri Linkov [this message]
2022-02-02 7:47 ` martin rudalics
2022-02-02 19:37 ` Juri Linkov
2022-02-06 17:55 ` Juri Linkov
2022-02-06 19:03 ` Aaron Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86leyuo3rn.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=53662@debbugs.gnu.org \
--cc=aaronjensen@gmail.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).