From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#53910: [External] : bug#53910: 29.0.50; context-menu-mode breaks help in read-only buffers Date: Sun, 20 Feb 2022 20:56:15 +0200 Organization: LINKOV.NET Message-ID: <86ley5e59s.fsf@mail.linkov.net> References: <20220210001600.vjiuqzoiuuzzj54c.ref@Ergus> <20220210001600.vjiuqzoiuuzzj54c@Ergus> <87mtizdwrv.fsf@gnus.org> <86y22jxfsq.fsf@mail.linkov.net> <87o83f7y3x.fsf@gnus.org> <86iltmpn0a.fsf@mail.linkov.net> <86wni13ifi.fsf@mail.linkov.net> <86pmns10kw.fsf@mail.linkov.net> <5d2c2af9-d011-583b-e9c1-985bbc2378c2@gmx.at> <861r06vbos.fsf@mail.linkov.net> <868ru9jnp6.fsf@mail.linkov.net> <86fsogocwx.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3754"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Lars Ingebrigtsen , Ergus , "53910@debbugs.gnu.org" <53910@debbugs.gnu.org> To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 20 20:00:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nLrRP-0000lk-Tg for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Feb 2022 20:00:15 +0100 Original-Received: from localhost ([::1]:38602 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nLrRO-0007PT-W2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Feb 2022 14:00:15 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50642) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nLrRE-0007Oq-2O for bug-gnu-emacs@gnu.org; Sun, 20 Feb 2022 14:00:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39833) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nLrRD-0002CL-I6 for bug-gnu-emacs@gnu.org; Sun, 20 Feb 2022 14:00:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nLrRD-0004qe-J8 for bug-gnu-emacs@gnu.org; Sun, 20 Feb 2022 14:00:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Feb 2022 19:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53910 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 53910-submit@debbugs.gnu.org id=B53910.164538356018547 (code B ref 53910); Sun, 20 Feb 2022 19:00:03 +0000 Original-Received: (at 53910) by debbugs.gnu.org; 20 Feb 2022 18:59:20 +0000 Original-Received: from localhost ([127.0.0.1]:33729 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLrQR-0004p0-8g for submit@debbugs.gnu.org; Sun, 20 Feb 2022 13:59:19 -0500 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:50859) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLrQL-0004oL-8E for 53910@debbugs.gnu.org; Sun, 20 Feb 2022 13:59:13 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 52036FF803; Sun, 20 Feb 2022 18:58:59 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Fri, 18 Feb 2022 03:32:40 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227265 Archived-At: >> If `context-menu-mode` is intended to work only on displayed buffers, >> is it really important to ensure that it also doesn't fail on >> non-window buffers? > > Yes, a :filter function in a keymap should not make such assumptions > (nor have side-effects, as a general rule). I can't find a way to prevent :filter from executing on context menus in help buffers, so I just removed `help-buffer-under-preparation` from :filter.