From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#53126: 29.0.50; [PATCH] Lazy highlight/count when reading query-replace string, etc. Date: Wed, 23 Mar 2022 21:53:41 +0200 Organization: LINKOV.NET Message-ID: <86lex01m4a.fsf@mail.linkov.net> References: <87sftyweb2.fsf@gmail.com> <861r1iyrvw.fsf@mail.linkov.net> <87zgo6owaf.fsf@gmail.com> <86k0f9xnrn.fsf@mail.linkov.net> <87tuedp6pl.fsf@gmail.com> <861r1g7n3b.fsf@mail.linkov.net> <87o84jcx5x.fsf@gmail.com> <8635lvif0r.fsf@mail.linkov.net> <87mtidip1w.fsf@gmail.com> <86sfrjia5u.fsf@mail.linkov.net> <87ilseyks7.fsf@gmail.com> <868rt9wwji.fsf@mail.linkov.net> <871qz11w82.fsf@gmail.com> <86ilsc7e31.fsf@mail.linkov.net> <87tubwz9dd.fsf@gmail.com> <86sfrc2zr8.fsf@mail.linkov.net> <87o820iedv.fsf@gmail.com> <86h77s2wqo.fsf@mail.linkov.net> <87k0coibrt.fsf@gmail.com> <864k3o3j1g.fsf@mail.linkov.net> <87k0ck7b55.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13728"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 53126@debbugs.gnu.org To: Augusto Stoffel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 23 20:55:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nX74l-0003TE-Dr for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Mar 2022 20:55:23 +0100 Original-Received: from localhost ([::1]:33082 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nX74j-0007dK-Nu for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Mar 2022 15:55:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59416) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nX74Q-0007dA-Fe for bug-gnu-emacs@gnu.org; Wed, 23 Mar 2022 15:55:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52209) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nX74Q-0005sj-7A for bug-gnu-emacs@gnu.org; Wed, 23 Mar 2022 15:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nX74Q-0005EG-5G for bug-gnu-emacs@gnu.org; Wed, 23 Mar 2022 15:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Mar 2022 19:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53126 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53126-submit@debbugs.gnu.org id=B53126.164806529220079 (code B ref 53126); Wed, 23 Mar 2022 19:55:02 +0000 Original-Received: (at 53126) by debbugs.gnu.org; 23 Mar 2022 19:54:52 +0000 Original-Received: from localhost ([127.0.0.1]:46106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nX74F-0005Dm-Or for submit@debbugs.gnu.org; Wed, 23 Mar 2022 15:54:51 -0400 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:60163) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nX74D-0005DV-LQ for 53126@debbugs.gnu.org; Wed, 23 Mar 2022 15:54:50 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id E8EB7E0002; Wed, 23 Mar 2022 19:54:41 +0000 (UTC) In-Reply-To: <87k0ck7b55.fsf@gmail.com> (Augusto Stoffel's message of "Wed, 23 Mar 2022 19:54:14 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228832 Archived-At: >> Unfortunately, there is a regression: isearch-yank-char-in-minibuffer >> bound to C-f and [right] in the minibuffer of isearch-edit-string >> doesn't work anymore. > > The following patch solves to problem for me. > > The point doesn't move visually, so selecting the isearch window puts it > in the right place. But what exactly happens to the point in the > searched buffer? I find this rather confusing! > > @@ -2670,7 +2670,7 @@ isearch-yank-char-in-minibuffer > (interactive "p") > (if (eobp) > (insert > - (with-current-buffer (cadr (buffer-list)) > + (with-minibuffer-selected-window Thanks, I confirm your patch fixes the problem. But before pushing it, I'd like to understand how your previous patches changed the order of the buffer list? Before your changes, (cadr (buffer-list)) returned the original buffer, but now it returns the minibuffer.