From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#60426: 29.0.60; Binding to outline-minor-mode-cycle-map correctly is unintuitive and hard Date: Wed, 11 Jan 2023 21:38:05 +0200 Organization: LINKOV.NET Message-ID: <86lem8vp42.fsf@mail.linkov.net> References: <871qohm8ht.fsf@zohomail.eu> <861qo95fzi.fsf@mail.linkov.net> <877cy0ztuj.fsf@zoho.eu> <86tu0ymc2s.fsf@mail.linkov.net> <87fschrpqw.fsf@zohomail.eu> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10727"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 60426@debbugs.gnu.org To: Rah Guzar Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 11 20:40:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pFgxS-0002g9-RR for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 11 Jan 2023 20:40:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pFgx9-0002PE-LB; Wed, 11 Jan 2023 14:40:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFgx8-0002P1-AX for bug-gnu-emacs@gnu.org; Wed, 11 Jan 2023 14:40:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pFgx7-00056p-SB for bug-gnu-emacs@gnu.org; Wed, 11 Jan 2023 14:40:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pFgx7-0003J2-Mm for bug-gnu-emacs@gnu.org; Wed, 11 Jan 2023 14:40:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Jan 2023 19:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60426 X-GNU-PR-Package: emacs Original-Received: via spool by 60426-submit@debbugs.gnu.org id=B60426.167346595512648 (code B ref 60426); Wed, 11 Jan 2023 19:40:01 +0000 Original-Received: (at 60426) by debbugs.gnu.org; 11 Jan 2023 19:39:15 +0000 Original-Received: from localhost ([127.0.0.1]:43925 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFgwN-0003Hv-2i for submit@debbugs.gnu.org; Wed, 11 Jan 2023 14:39:15 -0500 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]:59547) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFgwK-0003He-MH for 60426@debbugs.gnu.org; Wed, 11 Jan 2023 14:39:13 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id E2FB91BF203; Wed, 11 Jan 2023 19:39:01 +0000 (UTC) In-Reply-To: <87fschrpqw.fsf@zohomail.eu> (Rah Guzar's message of "Wed, 11 Jan 2023 17:29:22 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253161 Archived-At: > 1. I think in the NEWS entry, "font-lock text property 'keymap'" should > probably just be "text property 'keymap'" i.e. why mention font-lock? Thanks, now pushed to the emacs-29 branch with these corrections. > 2. Since the implementation of `outline-minor-mode-cycle--bind` can change, > it is better to change the order of arguments and make `map` an actual > third argument. It is awkward to pass `nil` as the first argument and I > think that way the actual map key is bound to can be treated as an > implementation detail with `outline-minor-mode-cycle--bind` the official > way of binding keys on headings. Even though it's like an "internal" function, I still hesitate to reorder its arguments to not break user configs. I'd rather add a new function without two hyphens as the official way to use it in personal customization: (defun outline-minor-mode-cycle-bind (key binding &optional filter map) (outline-minor-mode-cycle--bind map key binding &optional filter) and declare `outline-minor-mode-cycle--bind` obsolete.