From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mohsin Kaleem Newsgroups: gmane.emacs.bugs Subject: bug#62994: [PATCH v3 0/1] Support styled underlines on tty Emacs frames Date: Sun, 28 Jan 2024 12:30:25 +0100 Message-ID: <86le89itke.fsf@kisara.moe> References: <20230422102146.93003-1-mohkale@kisara.moe> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="334"; mail-complaints-to="usenet@ciao.gmane.io" To: Eli Zaretskii , 62994@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 28 12:31:21 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rU3Nh-000AUK-BB for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 28 Jan 2024 12:31:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rU3NM-0006US-16; Sun, 28 Jan 2024 06:31:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rU3NK-0006UJ-Si for bug-gnu-emacs@gnu.org; Sun, 28 Jan 2024 06:30:58 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rU3NG-0004rL-Q5 for bug-gnu-emacs@gnu.org; Sun, 28 Jan 2024 06:30:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rU3NO-00079h-4A for bug-gnu-emacs@gnu.org; Sun, 28 Jan 2024 06:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mohsin Kaleem Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Jan 2024 11:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62994 X-GNU-PR-Package: emacs Original-Received: via spool by 62994-submit@debbugs.gnu.org id=B62994.170644145227487 (code B ref 62994); Sun, 28 Jan 2024 11:31:02 +0000 Original-Received: (at 62994) by debbugs.gnu.org; 28 Jan 2024 11:30:52 +0000 Original-Received: from localhost ([127.0.0.1]:56768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rU3ND-00079G-Ns for submit@debbugs.gnu.org; Sun, 28 Jan 2024 06:30:51 -0500 Original-Received: from 119.ip-51-38-65.eu ([51.38.65.119]:41966 helo=mail.kisara.moe) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rU3N8-000793-Cd for 62994@debbugs.gnu.org; Sun, 28 Jan 2024 06:30:50 -0500 Original-Received: from kisara.moe (vps788627.ovh.net [51.38.65.119]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mail.kisara.moe (Postfix) with ESMTPSA id 5DE69A2795; Sun, 28 Jan 2024 12:30:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kisara.moe; s=default; t=1706441437; bh=ciCL4xeMRD9S61xlMOEt4uWiLmrLgKlhN7+hvHAFU9s=; h=From:To:Subject:In-Reply-To:References:Date:From; b=eg7D7HAUIxVwTgfAZ5MahlwbuD6B3ncQpq7PbmVr9C64TioA2KwE2W3ANEnoBw3LB YyQHEwhD+F2yRtfZEK67iHw9A5o6GXfPoRKeji5+VlCm/8zB1Tj2dxAVfh9+M5ssJ5 vG7sWjvUPqPQNkvd4ZlsyLV7B8QwfwRiCjE0Uj4V8j5o5IVlIfHYS9aSOIJ8p5DWiW XMuMk8csMuZjk1FXf7bfl1EzwewcDYZkfz8WrtNgZVUB3Nf1ofQGoqAyRaNb3hc8n6 vFDIxY0hRBnAj8ROu3AxWCtDJtlNC3OD+1l9r0mAm/7GMADl91BIKy5nxWRC2kxHCD zgrqapl5QkdqA== In-Reply-To: <20230422102146.93003-1-mohkale@kisara.moe> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279082 Archived-At: mohkale@kisara.moe writes: Hi there, My copyright situation should be solved now. I was waiting on something else from my work but would rather not put this off any longer. I've figured out how to do the correct resolution for color. Only thing that's confusing me a little is that in src/xfaces:6466 for map_tty_color it looks like we change the color in the face spec itself only on MSDOS frames. What are the ramifications of this? Is this logic we want to keep going forward? For reference I don't this should be done for the underline spec because unlike foreground and background it can be a string or a plist containing the color value and we would not want to update it in place. -- Mohsin Kaleem