From: Juri Linkov <juri@linkov.net>
To: Augusto Stoffel <arstoffel@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
70136@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#70136: 30.0.50; compilation-mode [was: comint-mode] doesn't call hack-dir-local-variables-non-file-buffer
Date: Thu, 02 May 2024 09:17:22 +0300 [thread overview]
Message-ID: <86le4s7n65.fsf@mail.linkov.net> (raw)
In-Reply-To: <87mspwcn0f.fsf_-_@gmail.com> (Augusto Stoffel's message of "Sun, 14 Apr 2024 11:27:28 +0200")
> @@ -2372,6 +2363,11 @@ compilation-mode
> ;; some other input event happens.
> (setq-local jit-lock-defer-time nil)
> (setq buffer-read-only t)
> + (unless (buffer-file-name)
> + (let ((sym (make-symbol "hack-dir-local-variables-non-file-buffer")))
> + (set sym #'hack-dir-local-variables-non-file-buffer)
> + ;; Ensure hack-dir-locals is called only after a derived mode is set.
> + (push sym delayed-mode-hooks)))
> (run-mode-hooks 'compilation-mode-hook))
Thanks for the patch. I confirm it completely fixes the bug
reported at the end of bug#68570.
prev parent reply other threads:[~2024-05-02 6:17 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 5:54 bug#70136: 30.0.50; comint-mode doesn't call hack-dir-local-variables-non-file-buffer Augusto Stoffel
2024-04-02 11:58 ` Eli Zaretskii
2024-04-02 14:03 ` Augusto Stoffel
2024-04-02 15:11 ` Eli Zaretskii
2024-04-14 9:16 ` Augusto Stoffel
2024-04-14 10:08 ` Eli Zaretskii
2024-04-14 9:27 ` bug#70136: 30.0.50; compilation-mode [was: comint-mode] " Augusto Stoffel
2024-04-14 10:21 ` Eli Zaretskii
2024-04-15 17:10 ` Augusto Stoffel
2024-04-15 18:27 ` Eli Zaretskii
2024-04-16 21:49 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-17 2:34 ` Eli Zaretskii
2024-04-17 2:58 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-17 8:31 ` Augusto Stoffel
2024-04-17 13:03 ` Eli Zaretskii
2024-04-17 13:29 ` bug#70436: 30.0.50; Fail to enter the debugger when using prin1 (instead of cl-prin1) Bruno Barbier
2024-04-20 8:24 ` Eli Zaretskii
2024-04-20 8:28 ` Eli Zaretskii
2024-04-20 15:24 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-25 16:37 ` Eli Zaretskii
2024-04-27 10:29 ` Bruno Barbier
2024-04-27 14:45 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-20 13:57 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-17 12:36 ` bug#70136: 30.0.50; compilation-mode [was: comint-mode] doesn't call hack-dir-local-variables-non-file-buffer Eli Zaretskii
2024-04-17 12:59 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-17 13:16 ` Eli Zaretskii
2024-04-17 17:55 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-17 18:18 ` Eli Zaretskii
2024-04-17 18:24 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-16 6:33 ` Juri Linkov
2024-04-16 12:37 ` Eli Zaretskii
2024-04-17 8:16 ` Augusto Stoffel
2024-04-17 13:00 ` Eli Zaretskii
2024-05-02 6:17 ` Juri Linkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86le4s7n65.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=70136@debbugs.gnu.org \
--cc=arstoffel@gmail.com \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).