From: Juri Linkov <juri@linkov.net>
To: Visuwesh <visuweshm@gmail.com>
Cc: 72147@debbugs.gnu.org
Subject: bug#72147: 30.0.60; 30.0.60; Misleading regexp highlighting in 'Q' dired command
Date: Fri, 19 Jul 2024 09:50:23 +0300 [thread overview]
Message-ID: <86le1xkh8w.fsf@mail.linkov.net> (raw)
In-Reply-To: <87r0bsn0ok.fsf@gmail.com> (Visuwesh's message of "Wed, 17 Jul 2024 09:13:07 +0530")
> When using the Q command in dired to query-replace-regexp across marked
> files in dired, the regexp typed in the first prompt highlights text in
> the _dired_ buffer.
>
> To reproduce,
>
> 1. emacs -Q
> 2. C-x d ~
> 3. Q -
>
> Notice how the dashes in the permission fields are highlighted. This is
> misleading and even confusing. It would be better to turn off regexp
> highlighting for this command. The attached patch does the job on my
> end. Let binding the variable this way does not turn off
> lazy-highlighting during the replacement.
>
> @@ -3801,9 +3801,10 @@ dired-do-query-replace-regexp
> (interactive
> - (let ((common
> - (query-replace-read-args
> - "Query replace regexp in marked files" t t)))
> + (let* ((query-replace-lazy-highlight)
> + (common
> + (query-replace-read-args
> + "Query replace regexp in marked files" t t)))
Thanks, I tried your patch, but it has no effect since
by default Q is bound to dired-do-find-regexp-and-replace.
Shouldn't query-replace-lazy-highlight be added to all
functions in dired that use query-replace-read-args?
next prev parent reply other threads:[~2024-07-19 6:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 3:43 bug#72147: 30.0.60; 30.0.60; Misleading regexp highlighting in 'Q' dired command Visuwesh
2024-07-19 6:50 ` Juri Linkov [this message]
2024-07-19 8:25 ` Visuwesh
2024-07-23 6:37 ` Juri Linkov
2024-07-23 9:27 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-23 17:40 ` Juri Linkov
2024-07-24 17:09 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-25 18:08 ` Juri Linkov
2024-07-28 4:59 ` Visuwesh
2024-07-28 6:54 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86le1xkh8w.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=72147@debbugs.gnu.org \
--cc=visuweshm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).