unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Christoph Badura <bad@bsd.de>
Cc: 72341@debbugs.gnu.org
Subject: bug#72341: VC: CVS template lines not stripped when committing
Date: Mon, 29 Jul 2024 05:26:50 +0300	[thread overview]
Message-ID: <86le1lylud.fsf@gnu.org> (raw)
In-Reply-To: <20240728192115.GY9440@irregular-apocalypse.k.bsd.de> (message from Christoph Badura on Sun, 28 Jul 2024 21:21:15 +0200)

> Date: Sun, 28 Jul 2024 21:21:15 +0200
> From: Christoph Badura <bad@bsd.de>
> 
> CVS only adds the template file and later strips the "CVS: " lines if
> you actually edit the commit message in an editor (which is invoked by
> cvs).  I.e. if you do not pass a commit message via "cvs ci -m'message'"
> or "cvs ci -F messagefile".
> 
> > If "cvs ci -m" doesn't strip the "CVS: " lines, then when and how does
> > the stripping you describe at the beginning happens?  And what does
> > the last part of the last sentence above, about the template file
> > being loaded when CVS invokes an editor, has to do with this issue?
> 
> When invoked as "cvs ci -m" (or "cvs ci -F") cvs uses the commit message
> *as is*.  With either option, cvs itself doesn't add the template file to
> the commit message and hence doesn't have to do any stripping.
> 
> log-edit-insert-cvs-template adds the CVS template file to the commit
> message outside of cvs.  Therefore log-edit has to strip the "CVS: " lines
> outside of cvs too.
> 
> Is that clearer?

Somewhat clearer, thanks.  I don't see this stripping feature
documented in the CVS manual; did I miss something?

And one more questions: where do those "CVS:" lines come from when you
use the template file?





  parent reply	other threads:[~2024-07-29  2:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-28 12:32 bug#72341: VC: CVS template lines not stripped when committing Christoph Badura
2024-07-28 17:49 ` Eli Zaretskii
2024-07-28 19:48   ` Christoph Badura
     [not found]   ` <20240728192115.GY9440@irregular-apocalypse.k.bsd.de>
2024-07-29  2:26     ` Eli Zaretskii [this message]
2024-07-29  9:53       ` Christoph Badura
2024-07-29 12:34         ` Eli Zaretskii
2024-07-29 15:02           ` Christoph Badura
2024-07-30 13:35           ` Dmitry Gutov
2024-08-02  7:19             ` Eli Zaretskii
2024-08-09 15:11               ` Christoph Badura

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86le1lylud.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=72341@debbugs.gnu.org \
    --cc=bad@bsd.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).