From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#54038: 29.0.50; doc-view cannot show different pages in different tabs Date: Mon, 29 Jul 2024 21:12:28 +0300 Organization: LINKOV.NET Message-ID: <86le1kt7sn.fsf@mail.linkov.net> References: <874k4xrgu5.fsf@gmail.com> <86wnhtjrb4.fsf@mail.linkov.net> <87fsohouaw.fsf@gmail.com> <86wnhslhli.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2854"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) Cc: 54038@debbugs.gnu.org To: Visuwesh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 29 20:19:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sYUxu-0000Ww-TU for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 29 Jul 2024 20:19:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sYUxQ-0005lm-0K; Mon, 29 Jul 2024 14:18:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sYUxO-0005gJ-5W for bug-gnu-emacs@gnu.org; Mon, 29 Jul 2024 14:18:50 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sYUxM-0006DC-S0 for bug-gnu-emacs@gnu.org; Mon, 29 Jul 2024 14:18:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=ymZwZw81kymUMUk8WZ5uW8w4/PbE5A3BtcdWNdH+TNc=; b=htiCvCLw0lSeAAmfbekjpigz6sRSMYw+xq1flgz3owqcyfdf3fjbiL6B3qv/Ts4dxLqrLkOJ54gjthTSGCpwVxZtyP0kIJlC+SdkdFnrGAt9vH6YEmGdUFcA0nCQ2RHTkk8XvCURpwLrw835StB8z3w6jM5Wq6usPwN2s5tdiVcJwbPrrLtMpw1ynZur97s6RcoFxfevlzruMDhe5FUVnc55bB8M4YyqqT/d8aok0QHoNcNa9N9OhF3d3Hy7L5knkirKMJ0FCTs2EQszGrsZyxgXKNAgbpihK5daIhcWIK4H9CWbUMcAZmg3X57EcOF3jSMmTY3uTYHyJh1D2YKz/Q==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sYUxZ-000313-Ix for bug-gnu-emacs@gnu.org; Mon, 29 Jul 2024 14:19:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Jul 2024 18:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54038 X-GNU-PR-Package: emacs Original-Received: via spool by 54038-submit@debbugs.gnu.org id=B54038.172227708511493 (code B ref 54038); Mon, 29 Jul 2024 18:19:01 +0000 Original-Received: (at 54038) by debbugs.gnu.org; 29 Jul 2024 18:18:05 +0000 Original-Received: from localhost ([127.0.0.1]:46306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sYUwf-0002zJ-FD for submit@debbugs.gnu.org; Mon, 29 Jul 2024 14:18:05 -0400 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:60453) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sYUwc-0002yZ-Or for 54038@debbugs.gnu.org; Mon, 29 Jul 2024 14:18:03 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id B6A551C0002; Mon, 29 Jul 2024 18:17:42 +0000 (UTC) In-Reply-To: <86wnhslhli.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 18 Feb 2022 10:11:21 +0200") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289526 Archived-At: > The problem is that when 'image-mode-winprops' does window cleanup, > it doesn't take into account windows saved in tabs. > > diff --git a/lisp/image-mode.el b/lisp/image-mode.el > index 5bee155460..c127df12ae 100644 > --- a/lisp/image-mode.el > +++ b/lisp/image-mode.el > @@ -179,7 +179,7 @@ image-mode-reapply-winprops > ;; Beware: this call to image-mode-winprops can't be optimized away, > ;; because it not only gets the winprops data but sets it up if needed > ;; (e.g. it's used by doc-view to display the image in a new window). > - (let* ((winprops (image-mode-winprops nil t)) > + (let* ((winprops (image-mode-winprops nil nil)) > (hscroll (image-mode-window-get 'hscroll winprops)) > (vscroll (image-mode-window-get 'vscroll winprops))) > (when (image-get-display-property) ;Only do it if we display an image! I see that Po Lu corrected display of Doc View documents after tab switching in the commit a475360af98. I tried the original report, but it still doesn't work without the patch above.