From: Juri Linkov <juri@linkov.net>
To: Visuwesh <visuweshm@gmail.com>
Cc: 54038@debbugs.gnu.org
Subject: bug#54038: 29.0.50; doc-view cannot show different pages in different tabs
Date: Mon, 29 Jul 2024 21:12:28 +0300 [thread overview]
Message-ID: <86le1kt7sn.fsf@mail.linkov.net> (raw)
In-Reply-To: <86wnhslhli.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 18 Feb 2022 10:11:21 +0200")
> The problem is that when 'image-mode-winprops' does window cleanup,
> it doesn't take into account windows saved in tabs.
>
> diff --git a/lisp/image-mode.el b/lisp/image-mode.el
> index 5bee155460..c127df12ae 100644
> --- a/lisp/image-mode.el
> +++ b/lisp/image-mode.el
> @@ -179,7 +179,7 @@ image-mode-reapply-winprops
> ;; Beware: this call to image-mode-winprops can't be optimized away,
> ;; because it not only gets the winprops data but sets it up if needed
> ;; (e.g. it's used by doc-view to display the image in a new window).
> - (let* ((winprops (image-mode-winprops nil t))
> + (let* ((winprops (image-mode-winprops nil nil))
> (hscroll (image-mode-window-get 'hscroll winprops))
> (vscroll (image-mode-window-get 'vscroll winprops)))
> (when (image-get-display-property) ;Only do it if we display an image!
I see that Po Lu corrected display of Doc View documents after tab switching
in the commit a475360af98. I tried the original report, but it still doesn't
work without the patch above.
prev parent reply other threads:[~2024-07-29 18:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 9:18 bug#54038: 29.0.50; doc-view cannot show different pages in different tabs Visuwesh
2022-02-17 18:12 ` Juri Linkov
2022-02-18 1:06 ` Visuwesh
2022-02-18 7:46 ` Juri Linkov
2022-02-19 17:31 ` Juri Linkov
2022-02-20 9:17 ` martin rudalics
2022-02-23 17:59 ` Juri Linkov
2022-02-18 8:11 ` Juri Linkov
2022-02-18 12:19 ` Visuwesh
2022-02-19 17:35 ` Juri Linkov
2022-02-20 9:17 ` martin rudalics
2022-02-20 18:51 ` Juri Linkov
2022-02-21 9:08 ` martin rudalics
2022-02-23 17:46 ` Juri Linkov
2022-02-24 9:18 ` martin rudalics
2024-07-29 18:12 ` Juri Linkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86le1kt7sn.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=54038@debbugs.gnu.org \
--cc=visuweshm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).