From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72405: 29.4; Doc string of `org-indent-mode' Date: Wed, 14 Aug 2024 09:12:38 +0300 Message-ID: <86le0zfx9l.fsf@gnu.org> References: <86cymsyguu.fsf@gnu.org> <877cd0iyw4.fsf@gmail.com> <8734noiy1b.fsf@gmail.com> <86zfpwwyu4.fsf@gnu.org> <87frr7zv3b.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="906"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72405@debbugs.gnu.org, monnier@iro.umontreal.ca, drew.adams@oracle.com To: Visuwesh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 14 08:13:50 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1se7GW-00004u-Ol for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Aug 2024 08:13:49 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1se7GE-00036i-DD; Wed, 14 Aug 2024 02:13:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1se7GC-00035q-GI for bug-gnu-emacs@gnu.org; Wed, 14 Aug 2024 02:13:29 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1se7GC-00082a-8G for bug-gnu-emacs@gnu.org; Wed, 14 Aug 2024 02:13:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=ITrLYEWgsuToeoCzdvZlk/6aGknwAW1THlwaInornhg=; b=OeCUIh7pK1Bph9D+AQt8/MSdz62h1+JNiU//XshsyWGyzP2XjW4uLhOTZBDI8QnvO0RLKKJLxaFC9OH+RMIvz3zNTRUNuwmTjWnXDTIDx3MlYX9VrKdLM0GZHOs5o+b75wLVL3EHvxSH/gXm/kWGu73P5hiYgkPyYqAXq28EshUcd8JQPg6Ih06DsCLIYbT8IHduibV9LP/M6ZX6pcGZtun31xCL0RxFZZIJhJ6wgULpkofU1XHNsdjmM2DJ94liv3wrCqqj8yMHZwjxTz+sgWsKex2VmsMPE5E/wP1YZy+B3uF1XFK2WWaSLzELd96aVKbQTPYh4Nx13pAB1qkdSg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1se7Gk-00017Y-4H for bug-gnu-emacs@gnu.org; Wed, 14 Aug 2024 02:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Aug 2024 06:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72405 X-GNU-PR-Package: emacs Original-Received: via spool by 72405-submit@debbugs.gnu.org id=B72405.17236160054252 (code B ref 72405); Wed, 14 Aug 2024 06:14:02 +0000 Original-Received: (at 72405) by debbugs.gnu.org; 14 Aug 2024 06:13:25 +0000 Original-Received: from localhost ([127.0.0.1]:45877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1se7G8-00016W-EM for submit@debbugs.gnu.org; Wed, 14 Aug 2024 02:13:24 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1se7G6-00016H-8N for 72405@debbugs.gnu.org; Wed, 14 Aug 2024 02:13:22 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1se7FR-0007z7-9b; Wed, 14 Aug 2024 02:12:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ITrLYEWgsuToeoCzdvZlk/6aGknwAW1THlwaInornhg=; b=E+osFjnNjYNN cjQ1Er6xWBnHaVmbTKjC3d7ze5kg5j/dcFiYR/vvyhjud72zvR+vcK+IbTeFR17rkyqr11yzHyaEu MoL5bNB9Zww324iHZOAiCZ3jRL6rcUrKpuInbhRd6nHM0xq1dnzD7WzBOwjmuJ6b6p37/l8DW7tGP DFoEKOlmaReYzwgFPvw0VoIeEWczJ++lmp1vPwwmOlANJVAx0tA6HbcOqHqKlM6zPkKWN05I/brGa BnWhBkWz6fi9hWGvaSriwEgFq/sVlsELXjodcLFTkl1powOlnN7Xa0UYSXvO1qQZMIaddIwjDvYam 87m9pSReKcSLdwWYcoP5ng==; In-Reply-To: <87frr7zv3b.fsf@gmail.com> (message from Visuwesh on Wed, 14 Aug 2024 08:09:20 +0530) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290115 Archived-At: > From: Visuwesh > Cc: Eli Zaretskii , 72405@debbugs.gnu.org, > drew.adams@oracle.com > Date: Wed, 14 Aug 2024 08:09:20 +0530 > > Thanks, so I've attached a properly formatted patch. > > > >From 535ae70653745f529742993f7fc26daf00666713 Mon Sep 17 00:00:00 2001 > From: Visuwesh > Date: Wed, 14 Aug 2024 08:07:15 +0530 > Subject: [PATCH] Disambiguate minor-mode variable in its function docstring > > * lisp/emacs-lisp/easy-mmode.el (easy-mmode--arg-docstring) > (easy-mmode--mode-docstring): Add "the variable" before the > GETTER if it is a symbol to properly link to minor-mode variable > in the *Help* buffer in the common case. (bug#72405) > --- > lisp/emacs-lisp/easy-mmode.el | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lisp/emacs-lisp/easy-mmode.el b/lisp/emacs-lisp/easy-mmode.el > index 944a74a91ee..5332a3b4fcf 100644 > --- a/lisp/emacs-lisp/easy-mmode.el > +++ b/lisp/emacs-lisp/easy-mmode.el > @@ -91,7 +91,7 @@ easy-mmode--arg-docstring > Disable the mode if ARG is a negative number. > > To check whether the minor mode is enabled in the current buffer, > -evaluate `%s'. > +evaluate %s`%s'. ^^^^^ This looks like a bug (I know it isn't, but it looks like one). Can we instead use just %s here, and generate the full string, including the "the variable" part, in the code that uses the format? Thanks.