From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73472: [PATCH] Substitute quotation marks in Eglot messages Date: Thu, 26 Sep 2024 08:52:06 +0300 Message-ID: <86ldzfarnd.fsf@gnu.org> References: <86setnbu3n.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16039"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73472@debbugs.gnu.org, joaotavora@gmail.com To: "Thomas Voss" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 26 07:55:05 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sthSy-00042s-IL for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Sep 2024 07:55:04 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sthSb-0001nr-Ib; Thu, 26 Sep 2024 01:54:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sthSX-0001nW-37 for bug-gnu-emacs@gnu.org; Thu, 26 Sep 2024 01:54:37 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sthSW-0001BP-QP for bug-gnu-emacs@gnu.org; Thu, 26 Sep 2024 01:54:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=FmI455X4npbnHIFV4QU1T3iFzd7MMcGCbOTzb7WJ16s=; b=ov2aZEtB6XnSbvA/IaaO8y/jaxUBDgv7/EqD3srCyEC152X1kKhPoBgyEAGn3X+SI84dXTuwzTIGBJ/AyWsWxayfiZHD4vXAW5/e73fw4zquonwBpWwOMJUDuQFpdAEKM+1BE9+QoL1oG2Lj8oFxVV0KhiiazXzB0IgxeTo27GlMyNOC9zC1OiuEp5tDEFZhyfZtSQP/i0QDWiyAL4aNegaJAWBbqohza/3Th6GzuOny6Ph1Qkl9yAD8uYzkyL9bLQv27r8BZr+u5GW+W4uq9YegHxNEOeioDOiaB/HmIEfKk3W2tODaUj5m49IMNf9N1Dm5ENIjnyggevzceywSEg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sthSv-0002Rm-VF for bug-gnu-emacs@gnu.org; Thu, 26 Sep 2024 01:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Sep 2024 05:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73472 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73472-submit@debbugs.gnu.org id=B73472.17273300939370 (code B ref 73472); Thu, 26 Sep 2024 05:55:01 +0000 Original-Received: (at 73472) by debbugs.gnu.org; 26 Sep 2024 05:54:53 +0000 Original-Received: from localhost ([127.0.0.1]:44126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sthSn-0002R4-E4 for submit@debbugs.gnu.org; Thu, 26 Sep 2024 01:54:53 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sthSl-0002QZ-L6 for 73472@debbugs.gnu.org; Thu, 26 Sep 2024 01:54:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sthQ8-00014V-1q; Thu, 26 Sep 2024 01:52:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=FmI455X4npbnHIFV4QU1T3iFzd7MMcGCbOTzb7WJ16s=; b=I55tZ5q57kJfrnVniSnY STmt9rmhmhMfJ+THtOzV/FF7eAFavrrBdkcZt1aZRDMcEQCtrmduQZA7lDBQQ+0qhguPFC+ptswQ8 JCNFgjjw7L0RVYyaLnCUg5bLId2WDSlHBSZXL16piwKiPzVm4zA7rpU+eUAppOn8jnoENUgk2O0Ux geEN92HeMFRGg4Oa9uzYijHQMczUbds+HVZfo6O1en+Mhz5tvK1tZuZGHkLrfPHM4Pl+v+Fv1mu+3 FX4/dueBqGoK7CL8ePJCRpIG9XwKUh9bkCt5a1jMbQ255GJGEDQCf5bB514meI/ygofXiNwNGoYCB ZRG8FridUlBt2w==; In-Reply-To: (mail@thomasvoss.com) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292435 Archived-At: > Date: Wed, 25 Sep 2024 20:03:20 +0200 > From: "Thomas Voss" > Cc: <73472@debbugs.gnu.org> > > Not sure why I didn’t think of this when creating the patch, but it’s > probably a much better idea to change this: > > (substitute-quotes (apply #'format format args)) > > to this: > > (apply #'format (substitute-quotes format) args) > > This limits the scope of the substitution to just the format strings, > where we know no funny business is going on. That is of course better, but do we indeed know that format will never use quote characters for something that is not quoting? I think the caller should itself use substitute-quotes where appropriate. And I'd like to hear João's opinion as well.